You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/07/29 15:32:12 UTC

Review Request 36911: Removed unnecessary using directive.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36911/
-----------------------------------------------------------

Review request for mesos, Marco Massenzio and Till Toenshoff.


Repository: mesos


Description
-------

Removed unnecessary using directive.


Diffs
-----

  src/master/master.cpp c584cb9f5aeb6806657059a3204ce1c680d4214a 

Diff: https://reviews.apache.org/r/36911/diff/


Testing
-------

make check (clang on Mac OS 10.10.4)


Thanks,

Alexander Rukletsov


Re: Review Request 36911: Removed unnecessary using directive.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36911/#review93957
-----------------------------------------------------------


Patch looks great!

Reviews applied: [36911]

All tests passed.

- Mesos ReviewBot


On Aug. 3, 2015, 2:58 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36911/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2015, 2:58 p.m.)
> 
> 
> Review request for mesos, Marco Massenzio and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unnecessary using directive.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp c584cb9f5aeb6806657059a3204ce1c680d4214a 
> 
> Diff: https://reviews.apache.org/r/36911/diff/
> 
> 
> Testing
> -------
> 
> make check (clang on Mac OS 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 36911: Removed unnecessary using directive.

Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36911/#review94036
-----------------------------------------------------------

Ship it!


Ship It!

- Alexander Rojas


On Aug. 3, 2015, 4:58 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36911/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2015, 4:58 p.m.)
> 
> 
> Review request for mesos, Marco Massenzio and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unnecessary using directive.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp c584cb9f5aeb6806657059a3204ce1c680d4214a 
> 
> Diff: https://reviews.apache.org/r/36911/diff/
> 
> 
> Testing
> -------
> 
> make check (clang on Mac OS 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 36911: Removed unnecessary using directive.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36911/#review94251
-----------------------------------------------------------

Ship it!


Ship It!

- Till Toenshoff


On Aug. 3, 2015, 2:58 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36911/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2015, 2:58 p.m.)
> 
> 
> Review request for mesos, Marco Massenzio and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unnecessary using directive.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp c584cb9f5aeb6806657059a3204ce1c680d4214a 
> 
> Diff: https://reviews.apache.org/r/36911/diff/
> 
> 
> Testing
> -------
> 
> make check (clang on Mac OS 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 36911: Removed unnecessary using directive.

Posted by Marco Massenzio <ma...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36911/#review93919
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Massenzio


On Aug. 3, 2015, 2:58 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36911/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2015, 2:58 p.m.)
> 
> 
> Review request for mesos, Marco Massenzio and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unnecessary using directive.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp c584cb9f5aeb6806657059a3204ce1c680d4214a 
> 
> Diff: https://reviews.apache.org/r/36911/diff/
> 
> 
> Testing
> -------
> 
> make check (clang on Mac OS 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Re: Review Request 36911: Removed unnecessary using directive.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36911/
-----------------------------------------------------------

(Updated Aug. 3, 2015, 2:58 p.m.)


Review request for mesos, Marco Massenzio and Till Toenshoff.


Changes
-------

Trigger ReviewBot.


Repository: mesos


Description
-------

Removed unnecessary using directive.


Diffs (updated)
-----

  src/master/master.cpp c584cb9f5aeb6806657059a3204ce1c680d4214a 

Diff: https://reviews.apache.org/r/36911/diff/


Testing
-------

make check (clang on Mac OS 10.10.4)


Thanks,

Alexander Rukletsov