You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2016/12/18 11:10:52 UTC
[GitHub] storm pull request #1833: STORM-2251 Integration test refers specific versio...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1833
STORM-2251 Integration test refers specific version of Storm which should be project version
* fix integration-test's pom.xml to have root pom as parent, and remove version and storm version
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-2251
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1833.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1833
----
commit fa8533f65741c778b547a924f5e31b5ffa05ea05
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2016-12-18T11:01:41Z
STORM-2251 Integration test refers specific version of Storm which should be project version
* fix integration-test's pom.xml to have root pom as parent, and remove version and storm version
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1833: STORM-2251 Integration test refers specific versio...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1833
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1833: STORM-2251 Integration test refers specific versio...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/1833#discussion_r92939531
--- Diff: integration-test/pom.xml ---
@@ -48,33 +53,6 @@
</profile>
</profiles>
- <repositories>
- <repository>
- <releases>
- <enabled>true</enabled>
- </releases>
- <snapshots>
- <enabled>false</enabled>
- </snapshots>
- <id>central</id>
- <url>http://repo1.maven.org/maven2/</url>
- </repository>
- <repository>
- <releases>
- <enabled>true</enabled>
- </releases>
- <snapshots>
- <enabled>true</enabled>
- </snapshots>
- <id>clojars</id>
- <url>https://clojars.org/repo/</url>
- </repository>
- <repository>
- <id>hortonworks</id>
- <url>http://nexus-private.hortonworks.com/nexus/content/groups/public/</url>
- </repository>
- </repositories>
-
<dependencies>
<dependency>
<groupId>org.testng</groupId>
--- End diff --
Consider removing joda-time version too, it's defined in the root pom's dependency management.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1833: STORM-2251 Integration test refers specific version of St...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the issue:
https://github.com/apache/storm/pull/1833
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1833: STORM-2251 Integration test refers specific versio...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1833#discussion_r92939727
--- Diff: integration-test/pom.xml ---
@@ -48,33 +53,6 @@
</profile>
</profiles>
- <repositories>
- <repository>
- <releases>
- <enabled>true</enabled>
- </releases>
- <snapshots>
- <enabled>false</enabled>
- </snapshots>
- <id>central</id>
- <url>http://repo1.maven.org/maven2/</url>
- </repository>
- <repository>
- <releases>
- <enabled>true</enabled>
- </releases>
- <snapshots>
- <enabled>true</enabled>
- </snapshots>
- <id>clojars</id>
- <url>https://clojars.org/repo/</url>
- </repository>
- <repository>
- <id>hortonworks</id>
- <url>http://nexus-private.hortonworks.com/nexus/content/groups/public/</url>
- </repository>
- </repositories>
-
<dependencies>
<dependency>
<groupId>org.testng</groupId>
--- End diff --
Addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1833: STORM-2251 Integration test refers specific version of St...
Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/1833
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---