You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/06/06 08:04:15 UTC

[kudu-CR] KUDU-2809 (5/6): add diff scan support to fuzz-itest

Hello Will Berkeley, Mike Percy, Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/13537

to review the following change.


Change subject: KUDU-2809 (5/6): add diff scan support to fuzz-itest
......................................................................

KUDU-2809 (5/6): add diff scan support to fuzz-itest

This patch adds diff scans to the set of operations supported by fuzz-itest.
The existing saved_values_ map is quite difficult to reuse for verifying
diff scan results, so instead I added a saved_redos_ map that tracks every
insertion/mutation as a discrete "redo".

For coverage, there are two new tests for KUDU-2809. I also ran fuzz-itest
in slow mode a few thousands times on this patch series without failure.

Change-Id: I3f7dae20ef1b903dba80e90d5f491e4322815fbb
---
M src/kudu/integration-tests/fuzz-itest.cc
M src/kudu/tablet/key_value_test_schema.h
2 files changed, 260 insertions(+), 16 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/13537/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f7dae20ef1b903dba80e90d5f491e4322815fbb
Gerrit-Change-Number: 13537
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] KUDU-2809 (5/6): add diff scan support to fuzz-itest

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change.  ( http://gerrit.cloudera.org:8080/13537 )

Change subject: KUDU-2809 (5/6): add diff scan support to fuzz-itest
......................................................................


Removed reviewer Kudu Jenkins with the following votes:

* Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/13537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I3f7dae20ef1b903dba80e90d5f491e4322815fbb
Gerrit-Change-Number: 13537
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] KUDU-2809 (5/6): add diff scan support to fuzz-itest

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13537

to look at the new patch set (#8).

Change subject: KUDU-2809 (5/6): add diff scan support to fuzz-itest
......................................................................

KUDU-2809 (5/6): add diff scan support to fuzz-itest

This patch adds diff scans to the set of operations supported by fuzz-itest.
The existing saved_values_ map is quite difficult to reuse for verifying
diff scan results, so instead I added a saved_redos_ map that tracks every
insertion/mutation as a discrete "redo".

For coverage, there are two new tests for KUDU-2809. I also ran fuzz-itest
in slow mode a few thousands times on this patch series without failure.

Change-Id: I3f7dae20ef1b903dba80e90d5f491e4322815fbb
---
M src/kudu/integration-tests/fuzz-itest.cc
M src/kudu/tablet/key_value_test_schema.h
2 files changed, 262 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/13537/8
-- 
To view, visit http://gerrit.cloudera.org:8080/13537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3f7dae20ef1b903dba80e90d5f491e4322815fbb
Gerrit-Change-Number: 13537
Gerrit-PatchSet: 8
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] KUDU-2809 (5/6): add diff scan support to fuzz-itest

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13537 )

Change subject: KUDU-2809 (5/6): add diff scan support to fuzz-itest
......................................................................


Patch Set 3: Verified+1

Overriding Jenkins, unrelated AlterTableRandomized flake.


-- 
To view, visit http://gerrit.cloudera.org:8080/13537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f7dae20ef1b903dba80e90d5f491e4322815fbb
Gerrit-Change-Number: 13537
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Thu, 06 Jun 2019 17:30:57 +0000
Gerrit-HasComments: No

[kudu-CR] KUDU-2809 (5/6): add diff scan support to fuzz-itest

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Tidy Bot, Mike Percy, Kudu Jenkins, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13537

to look at the new patch set (#3).

Change subject: KUDU-2809 (5/6): add diff scan support to fuzz-itest
......................................................................

KUDU-2809 (5/6): add diff scan support to fuzz-itest

This patch adds diff scans to the set of operations supported by fuzz-itest.
The existing saved_values_ map is quite difficult to reuse for verifying
diff scan results, so instead I added a saved_redos_ map that tracks every
insertion/mutation as a discrete "redo".

For coverage, there are two new tests for KUDU-2809. I also ran fuzz-itest
in slow mode a few thousands times on this patch series without failure.

Change-Id: I3f7dae20ef1b903dba80e90d5f491e4322815fbb
---
M src/kudu/integration-tests/fuzz-itest.cc
M src/kudu/tablet/key_value_test_schema.h
2 files changed, 263 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/13537/3
-- 
To view, visit http://gerrit.cloudera.org:8080/13537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3f7dae20ef1b903dba80e90d5f491e4322815fbb
Gerrit-Change-Number: 13537
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] KUDU-2809 (5/6): add diff scan support to fuzz-itest

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13537 )

Change subject: KUDU-2809 (5/6): add diff scan support to fuzz-itest
......................................................................

KUDU-2809 (5/6): add diff scan support to fuzz-itest

This patch adds diff scans to the set of operations supported by fuzz-itest.
The existing saved_values_ map is quite difficult to reuse for verifying
diff scan results, so instead I added a saved_redos_ map that tracks every
insertion/mutation as a discrete "redo".

For coverage, there are two new tests for KUDU-2809. I also ran fuzz-itest
in slow mode a few thousands times on this patch series without failure.

Change-Id: I3f7dae20ef1b903dba80e90d5f491e4322815fbb
Reviewed-on: http://gerrit.cloudera.org:8080/13537
Reviewed-by: Mike Percy <mp...@apache.org>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/fuzz-itest.cc
M src/kudu/tablet/key_value_test_schema.h
2 files changed, 262 insertions(+), 18 deletions(-)

Approvals:
  Mike Percy: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3f7dae20ef1b903dba80e90d5f491e4322815fbb
Gerrit-Change-Number: 13537
Gerrit-PatchSet: 9
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] KUDU-2809 (5/6): add diff scan support to fuzz-itest

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13537 )

Change subject: KUDU-2809 (5/6): add diff scan support to fuzz-itest
......................................................................


Patch Set 7: Code-Review+1

(3 comments)

http://gerrit.cloudera.org:8080/#/c/13537/7/src/kudu/integration-tests/fuzz-itest.cc
File src/kudu/integration-tests/fuzz-itest.cc:

http://gerrit.cloudera.org:8080/#/c/13537/7/src/kudu/integration-tests/fuzz-itest.cc@603
PS7, Line 603: ignored
nit: /*expected_row*/ (ignored is clear from being commented out)


http://gerrit.cloudera.org:8080/#/c/13537/7/src/kudu/integration-tests/fuzz-itest.cc@612
PS7, Line 612: ignored
nit: I think a better name would be /*is_deleted*/ or /*element*/


http://gerrit.cloudera.org:8080/#/c/13537/7/src/kudu/integration-tests/fuzz-itest.cc@615
PS7, Line 615: row_key++;
This is pretty clever... is this relying on defined behavior for std::remove_if()?



-- 
To view, visit http://gerrit.cloudera.org:8080/13537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f7dae20ef1b903dba80e90d5f491e4322815fbb
Gerrit-Change-Number: 13537
Gerrit-PatchSet: 7
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 18:34:46 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2809 (5/6): add diff scan support to fuzz-itest

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13537 )

Change subject: KUDU-2809 (5/6): add diff scan support to fuzz-itest
......................................................................


Patch Set 8: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13537/7/src/kudu/integration-tests/fuzz-itest.cc
File src/kudu/integration-tests/fuzz-itest.cc:

http://gerrit.cloudera.org:8080/#/c/13537/7/src/kudu/integration-tests/fuzz-itest.cc@615
PS7, Line 615: row_key++;
> It's basically a silly way to maintain an index for expected_is_deleted whi
Yeah, it's called the erase-remove idiom and it's O(n) which is good for a bulk delete on a vector. Sounds good.



-- 
To view, visit http://gerrit.cloudera.org:8080/13537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f7dae20ef1b903dba80e90d5f491e4322815fbb
Gerrit-Change-Number: 13537
Gerrit-PatchSet: 8
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 22:15:08 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2809 (5/6): add diff scan support to fuzz-itest

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Tidy Bot, Mike Percy, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13537

to look at the new patch set (#4).

Change subject: KUDU-2809 (5/6): add diff scan support to fuzz-itest
......................................................................

KUDU-2809 (5/6): add diff scan support to fuzz-itest

This patch adds diff scans to the set of operations supported by fuzz-itest.
The existing saved_values_ map is quite difficult to reuse for verifying
diff scan results, so instead I added a saved_redos_ map that tracks every
insertion/mutation as a discrete "redo".

For coverage, there are two new tests for KUDU-2809. I also ran fuzz-itest
in slow mode a few thousands times on this patch series without failure.

Change-Id: I3f7dae20ef1b903dba80e90d5f491e4322815fbb
---
M src/kudu/integration-tests/fuzz-itest.cc
M src/kudu/tablet/key_value_test_schema.h
2 files changed, 262 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/13537/4
-- 
To view, visit http://gerrit.cloudera.org:8080/13537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3f7dae20ef1b903dba80e90d5f491e4322815fbb
Gerrit-Change-Number: 13537
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>

[kudu-CR] KUDU-2809 (5/6): add diff scan support to fuzz-itest

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13537 )

Change subject: KUDU-2809 (5/6): add diff scan support to fuzz-itest
......................................................................


Patch Set 8:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/13537/7/src/kudu/integration-tests/fuzz-itest.cc
File src/kudu/integration-tests/fuzz-itest.cc:

http://gerrit.cloudera.org:8080/#/c/13537/7/src/kudu/integration-tests/fuzz-itest.cc@603
PS7, Line 603: row*/) 
> nit: /*expected_row*/ (ignored is clear from being commented out)
Will use 'row' to be more consistent with 'is_deleted' below.


http://gerrit.cloudera.org:8080/#/c/13537/7/src/kudu/integration-tests/fuzz-itest.cc@612
PS7, Line 612: is_dele
> nit: I think a better name would be /*is_deleted*/ or /*element*/
Done


http://gerrit.cloudera.org:8080/#/c/13537/7/src/kudu/integration-tests/fuzz-itest.cc@615
PS7, Line 615: row_key++;
> This is pretty clever... is this relying on defined behavior for std::remov
It's basically a silly way to maintain an index for expected_is_deleted while still calling erase with remove_if (which is a more efficient way to erase). So it's actually relying on erase(..., start_iter, end_iter) semantics, which, if you pass in vector::begin and vector::end, gives you in-index-order iteration.



-- 
To view, visit http://gerrit.cloudera.org:8080/13537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f7dae20ef1b903dba80e90d5f491e4322815fbb
Gerrit-Change-Number: 13537
Gerrit-PatchSet: 8
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 07 Jun 2019 21:34:24 +0000
Gerrit-HasComments: Yes

[kudu-CR] KUDU-2809 (5/6): add diff scan support to fuzz-itest

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Mike Percy, Kudu Jenkins, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13537

to look at the new patch set (#2).

Change subject: KUDU-2809 (5/6): add diff scan support to fuzz-itest
......................................................................

KUDU-2809 (5/6): add diff scan support to fuzz-itest

This patch adds diff scans to the set of operations supported by fuzz-itest.
The existing saved_values_ map is quite difficult to reuse for verifying
diff scan results, so instead I added a saved_redos_ map that tracks every
insertion/mutation as a discrete "redo".

For coverage, there are two new tests for KUDU-2809. I also ran fuzz-itest
in slow mode a few thousands times on this patch series without failure.

Change-Id: I3f7dae20ef1b903dba80e90d5f491e4322815fbb
---
M src/kudu/integration-tests/fuzz-itest.cc
M src/kudu/tablet/key_value_test_schema.h
2 files changed, 263 insertions(+), 18 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/13537/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3f7dae20ef1b903dba80e90d5f491e4322815fbb
Gerrit-Change-Number: 13537
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>