You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Suresh Thalamati (JIRA)" <de...@db.apache.org> on 2006/01/24 03:31:32 UTC
[jira] Updated: (DERBY-665) Remove backup(File ...) methods
[ http://issues.apache.org/jira/browse/DERBY-665?page=all ]
Suresh Thalamati updated DERBY-665:
-----------------------------------
Attachment: derby665.diff
This patch removes the unused bacpup functions with File as paramteter,
TESTS : derbyall test suite passed on Windows XP/JDK142
It would be great if some can review and commit this patch.
svn stat:
M java\engine\org\apache\derby\impl\db\BasicDatabase.java
M java\engine\org\apache\derby\impl\store\access\RAMAccessManager.java
M java\engine\org\apache\derby\impl\store\raw\RawStore.java
M java\engine\org\apache\derby\iapi\store\access\AccessFactory.java
M java\engine\org\apache\derby\iapi\store\raw\RawStoreFactory.java
M java\engine\org\apache\derby\database\Database.java
> Remove backup(File ...) methods
> -------------------------------
>
> Key: DERBY-665
> URL: http://issues.apache.org/jira/browse/DERBY-665
> Project: Derby
> Type: Improvement
> Components: Store
> Versions: 10.2.0.0
> Environment: Any
> Reporter: Øystein Grøvlen
> Assignee: Suresh Thalamati
> Priority: Minor
> Attachments: derby665.diff
>
> The code contains backup methods both for specifying the backup directory both as a String and as a File parameter. Only the String versions are currently used. The File versions should be removed to avoid duplication of code etc.
> Examples of such methods are:
> BasicDatabase.backup
> BasicDatabase.backupAndEnableLogArchiveMode
> RAMAccessManager.backup
> RAMAccessManager.backupAndEnableLogArchiveMode
> RawStore.backupAndEnableLogArchiveMode
> plus corresponding interfaces.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
Re: [jira] Updated: (DERBY-665) Remove backup(File ...) methods
Posted by Mike Matrigali <mi...@sbcglobal.net>.
I have committed this patch. Derbyall ran clean on XP and sun jdk1.4.2.
Mike Matrigali wrote:
> I am looking at committing this patch.
>
> Suresh Thalamati (JIRA) wrote:
>
>
>> [ http://issues.apache.org/jira/browse/DERBY-665?page=all ]
>>
>>Suresh Thalamati updated DERBY-665:
>>-----------------------------------
>>
>> Attachment: derby665.diff
>>
>>This patch removes the unused bacpup functions with File as paramteter,
>>TESTS : derbyall test suite passed on Windows XP/JDK142
>>
>>It would be great if some can review and commit this patch.
>>
>>
>>svn stat:
>>M java\engine\org\apache\derby\impl\db\BasicDatabase.java
>>M java\engine\org\apache\derby\impl\store\access\RAMAccessManager.java
>>M java\engine\org\apache\derby\impl\store\raw\RawStore.java
>>M java\engine\org\apache\derby\iapi\store\access\AccessFactory.java
>>M java\engine\org\apache\derby\iapi\store\raw\RawStoreFactory.java
>>M java\engine\org\apache\derby\database\Database.java
>>
>>
>>
>>
>>>Remove backup(File ...) methods
>>>-------------------------------
>>>
>>> Key: DERBY-665
>>> URL: http://issues.apache.org/jira/browse/DERBY-665
>>> Project: Derby
>>> Type: Improvement
>>> Components: Store
>>> Versions: 10.2.0.0
>>>Environment: Any
>>> Reporter: Øystein Grøvlen
>>> Assignee: Suresh Thalamati
>>> Priority: Minor
>>>Attachments: derby665.diff
>>>
>>>The code contains backup methods both for specifying the backup directory both as a String and as a File parameter. Only the String versions are currently used. The File versions should be removed to avoid duplication of code etc.
>>>Examples of such methods are:
>>>BasicDatabase.backup
>>>BasicDatabase.backupAndEnableLogArchiveMode
>>>RAMAccessManager.backup
>>>RAMAccessManager.backupAndEnableLogArchiveMode
>>>RawStore.backupAndEnableLogArchiveMode
>>>plus corresponding interfaces.
>>
>>
>
>
Re: [jira] Updated: (DERBY-665) Remove backup(File ...) methods
Posted by Mike Matrigali <mi...@sbcglobal.net>.
I am looking at committing this patch.
Suresh Thalamati (JIRA) wrote:
> [ http://issues.apache.org/jira/browse/DERBY-665?page=all ]
>
> Suresh Thalamati updated DERBY-665:
> -----------------------------------
>
> Attachment: derby665.diff
>
> This patch removes the unused bacpup functions with File as paramteter,
> TESTS : derbyall test suite passed on Windows XP/JDK142
>
> It would be great if some can review and commit this patch.
>
>
> svn stat:
> M java\engine\org\apache\derby\impl\db\BasicDatabase.java
> M java\engine\org\apache\derby\impl\store\access\RAMAccessManager.java
> M java\engine\org\apache\derby\impl\store\raw\RawStore.java
> M java\engine\org\apache\derby\iapi\store\access\AccessFactory.java
> M java\engine\org\apache\derby\iapi\store\raw\RawStoreFactory.java
> M java\engine\org\apache\derby\database\Database.java
>
>
>
>>Remove backup(File ...) methods
>>-------------------------------
>>
>> Key: DERBY-665
>> URL: http://issues.apache.org/jira/browse/DERBY-665
>> Project: Derby
>> Type: Improvement
>> Components: Store
>> Versions: 10.2.0.0
>> Environment: Any
>> Reporter: Øystein Grøvlen
>> Assignee: Suresh Thalamati
>> Priority: Minor
>> Attachments: derby665.diff
>>
>>The code contains backup methods both for specifying the backup directory both as a String and as a File parameter. Only the String versions are currently used. The File versions should be removed to avoid duplication of code etc.
>>Examples of such methods are:
>>BasicDatabase.backup
>>BasicDatabase.backupAndEnableLogArchiveMode
>>RAMAccessManager.backup
>>RAMAccessManager.backupAndEnableLogArchiveMode
>>RawStore.backupAndEnableLogArchiveMode
>>plus corresponding interfaces.
>
>