You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/10/12 23:15:40 UTC

[GitHub] [couchdb] jaydoane opened a new pull request, #4205: Quiet prometheus end to end tests

jaydoane opened a new pull request, #4205:
URL: https://github.com/apache/couchdb/pull/4205

   
   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   
   <!-- Please give a short brief for the pull request,
        what problem it solves or how it makes things better. -->
   
   Currently, applications are restarted during individual tests, resulting in noisy output:
   ```
   module 'couch_prometheus_e2e_tests'
     Prometheus E2E Tests
       couch_prometheus_e2e_tests:66: node_call_chttpd...ok
   Application config was left running!
   Application asn1 was left running!
   Application b64url was left running!
   Application public_key was left running!
   Application ssl was left running!
   Application couch_dist was left running!
   Application couch_epi was left running!
   Application khash was left running!
   Application couch_event was left running!
   Application folsom was left running!
   Application couch_stats was left running!
   Application hyper was left running!
   Application ibrowse was left running!
   Application inets was left running!
   Application hqueue was left running!
   Application compiler was left running!
   Application syntax_tools was left running!
   Application xmerl was left running!
   Application mochiweb was left running!
   Application sasl was left running!
   Application ets_lru was left running!
   Application rexi was left running!
   Application fabric was left running!
       couch_prometheus_e2e_tests:98: node_call_prometheus_http...ok
   Application config was left running!
   Application asn1 was left running!
   Application b64url was left running!
   Application public_key was left running!
   Application ssl was left running!
   Application couch_dist was left running!
   Application couch_epi was left running!
   Application khash was left running!
   Application couch_event was left running!
   Application folsom was left running!
   Application couch_stats was left running!
   Application hyper was left running!
   Application ibrowse was left running!
   Application inets was left running!
   Application hqueue was left running!
   Application compiler was left running!
   Application syntax_tools was left running!
   Application xmerl was left running!
   Application mochiweb was left running!
   Application sasl was left running!
   Application ets_lru was left running!
   Application rexi was left running!
   Application fabric was left running!
       couch_prometheus_e2e_tests:109: deny_prometheus_http...ok
       couch_prometheus_e2e_tests:82: node_see_updated_metrics...ok
       [done in 6.595 s]
     [done in 8.739 s]
   ```
   This factors the current test generator into two, one where a separate prometheus HTTP server is started on a dedicated port, and one where it is not, which prevents the noise.
   
   Additionally, tests have been changed to use the TDEF_FE macro, cleaned up, and renamed to make them easier to understand.
   
   ## Testing recommendations
   
   ```
   make eunit apps=couch_prometheus suites=couch_prometheus_e2e_tests
   ```
   <!-- Describe how we can test your changes.
        Does it provides any behaviour that the end users
        could notice? -->
   
   ## Related Issues or Pull Requests
   
   <!-- If your changes affects multiple components in different
        repositories please put links to those issues or pull requests here.  -->
   
   ## Checklist
   
   - [x] Code is written and works correctly
   - [x] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] Documentation changes were made in the `src/docs` folder
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] jaydoane merged pull request #4205: Quiet prometheus end to end tests

Posted by GitBox <gi...@apache.org>.
jaydoane merged PR #4205:
URL: https://github.com/apache/couchdb/pull/4205


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org