[GitHub] [drill] paul-rogers commented on issue #1913: DRILL-6953: EVF-based version of the JSON reader

[GitBox <gi...@apache.org>]

paul-rogers commented on issue #1913: DRILL-6953: EVF-based version of the JSON reader
URL: https://github.com/apache/drill/pull/1913#issuecomment-560030850
 
 
   Some background: this PR includes work completed about two years ago as part of the "row set" (EVF) project. We had to first get the EVF itself reviewed and merged, then we added provided schema support. The first attempt to merge the JSON reader uncovered many issues with batch, record and vector counts. Those have been fixed over the last couple of months. This time, the unit tests pass with the new JSON reader.
   
   This PR leaves the old "V1" reader enabled by default. More testing is required before we enable the "V2" reader by default.
   
   Because this work pre-dated the "provided schema" work, it does not yet support the provided schema. Let's get this version merged, then we can add the additional work needed to support a provided schema.
   
   Also, any work done in the "V1" JSON reader in the last two years is not yet reflected in the "V2" version. We make any such changes after this PR.
   
   JSON is a surprisingly complex and tricky format. Suggestions for further tests or improvements are welcome.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services