You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nutch.apache.org by "Julien Nioche (JIRA)" <ji...@apache.org> on 2010/07/13 18:10:50 UTC
[jira] Created: (NUTCH-851) Port logging to slf4j
Port logging to slf4j
---------------------
Key: NUTCH-851
URL: https://issues.apache.org/jira/browse/NUTCH-851
Project: Nutch
Issue Type: New Feature
Reporter: Julien Nioche
Fix For: 2.0
We are already inheriting a dependency on slf4j from Solr so we might as well use it :-)
Any thoughts on this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (NUTCH-851) Port logging to slf4j
Posted by "Pham Tuan Minh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888164#action_12888164 ]
Pham Tuan Minh commented on NUTCH-851:
--------------------------------------
I'm a fan of Log4j, but I love something is simple, compact and no more dependencies like JDK logging.
By this, it allows end user to choose their desired logging framework at deployment time. It's very interesting feature!
> Port logging to slf4j
> ---------------------
>
> Key: NUTCH-851
> URL: https://issues.apache.org/jira/browse/NUTCH-851
> Project: Nutch
> Issue Type: New Feature
> Reporter: Julien Nioche
> Fix For: 2.0
>
>
> We are already inheriting a dependency on slf4j from Solr so we might as well use it :-)
> Any thoughts on this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (NUTCH-851) Port logging to slf4j
Posted by "Julien Nioche (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julien Nioche updated NUTCH-851:
--------------------------------
Attachment: (was: NUTCH-851.patch)
> Port logging to slf4j
> ---------------------
>
> Key: NUTCH-851
> URL: https://issues.apache.org/jira/browse/NUTCH-851
> Project: Nutch
> Issue Type: New Feature
> Reporter: Julien Nioche
> Fix For: 2.0
>
> Attachments: NUTCH-851-v2.patch
>
>
> We are already inheriting a dependency on slf4j from Solr so we might as well use it :-)
> Any thoughts on this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (NUTCH-851) Port logging to slf4j
Posted by "Andrzej Bialecki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887963#action_12887963 ]
Andrzej Bialecki commented on NUTCH-851:
-----------------------------------------
Definitely, +1.
> Port logging to slf4j
> ---------------------
>
> Key: NUTCH-851
> URL: https://issues.apache.org/jira/browse/NUTCH-851
> Project: Nutch
> Issue Type: New Feature
> Reporter: Julien Nioche
> Fix For: 2.0
>
>
> We are already inheriting a dependency on slf4j from Solr so we might as well use it :-)
> Any thoughts on this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (NUTCH-851) Port logging to slf4j
Posted by "Julien Nioche (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julien Nioche updated NUTCH-851:
--------------------------------
Attachment: NUTCH-851.patch
Used the migrator tool from slf4j http://www.slf4j.org/migrator.html + manually replaced fatal() by error() + various minor fixes
I have commented out the dependency on commons-logging but left the log4j adapter (slf4j-log4j12) so that we are now using log4j through slf4j. The beauty of it is that users can swap to their favourite logging system by replacing the ivy dependencies
The patch compiles and goes through the tests OK
> Port logging to slf4j
> ---------------------
>
> Key: NUTCH-851
> URL: https://issues.apache.org/jira/browse/NUTCH-851
> Project: Nutch
> Issue Type: New Feature
> Reporter: Julien Nioche
> Fix For: 2.0
>
> Attachments: NUTCH-851.patch
>
>
> We are already inheriting a dependency on slf4j from Solr so we might as well use it :-)
> Any thoughts on this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (NUTCH-851) Port logging to slf4j
Posted by "Chris A. Mattmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888082#action_12888082 ]
Chris A. Mattmann commented on NUTCH-851:
-----------------------------------------
LOL yep I'm sort of a fan of JDK logging b/c it doesn't introduce extra dependencies. To be honest, most of the logging frameworks all look the same to me, but it's probably b/c I haven't compared them in detail. :)
The facetious part though is that I don't really feel strongly about it to do anything but boo to adding extra dependencies :)
> Port logging to slf4j
> ---------------------
>
> Key: NUTCH-851
> URL: https://issues.apache.org/jira/browse/NUTCH-851
> Project: Nutch
> Issue Type: New Feature
> Reporter: Julien Nioche
> Fix For: 2.0
>
>
> We are already inheriting a dependency on slf4j from Solr so we might as well use it :-)
> Any thoughts on this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (NUTCH-851) Port logging to slf4j
Posted by "Julien Nioche (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julien Nioche updated NUTCH-851:
--------------------------------
Attachment: NUTCH-851-v2.patch
Updated the patch to the 2.0 code.
Will commit tomorrow if there aren't any objections
> Port logging to slf4j
> ---------------------
>
> Key: NUTCH-851
> URL: https://issues.apache.org/jira/browse/NUTCH-851
> Project: Nutch
> Issue Type: New Feature
> Reporter: Julien Nioche
> Fix For: 2.0
>
> Attachments: NUTCH-851-v2.patch
>
>
> We are already inheriting a dependency on slf4j from Solr so we might as well use it :-)
> Any thoughts on this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (NUTCH-851) Port logging to slf4j
Posted by "Chris A. Mattmann (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887966#action_12887966 ]
Chris A. Mattmann commented on NUTCH-851:
-----------------------------------------
Boo! :)
...fan of JDK logging...
> Port logging to slf4j
> ---------------------
>
> Key: NUTCH-851
> URL: https://issues.apache.org/jira/browse/NUTCH-851
> Project: Nutch
> Issue Type: New Feature
> Reporter: Julien Nioche
> Fix For: 2.0
>
>
> We are already inheriting a dependency on slf4j from Solr so we might as well use it :-)
> Any thoughts on this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (NUTCH-851) Port logging to slf4j
Posted by "Julien Nioche (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julien Nioche reassigned NUTCH-851:
-----------------------------------
Assignee: Julien Nioche
> Port logging to slf4j
> ---------------------
>
> Key: NUTCH-851
> URL: https://issues.apache.org/jira/browse/NUTCH-851
> Project: Nutch
> Issue Type: New Feature
> Reporter: Julien Nioche
> Assignee: Julien Nioche
> Fix For: 2.0
>
> Attachments: NUTCH-851-v2.patch
>
>
> We are already inheriting a dependency on slf4j from Solr so we might as well use it :-)
> Any thoughts on this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (NUTCH-851) Port logging to slf4j
Posted by "Andrzej Bialecki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887984#action_12887984 ]
Andrzej Bialecki commented on NUTCH-851:
-----------------------------------------
You are being facetious, aren't you. JDK logging is arguably the worst logging API (if you dismiss System.out.println), giving you the least control and flexibility. Slf4j is the opposite, and allows you even to use JDK logging, if that's what you like...
And we have to include slf4j anyway.
> Port logging to slf4j
> ---------------------
>
> Key: NUTCH-851
> URL: https://issues.apache.org/jira/browse/NUTCH-851
> Project: Nutch
> Issue Type: New Feature
> Reporter: Julien Nioche
> Fix For: 2.0
>
>
> We are already inheriting a dependency on slf4j from Solr so we might as well use it :-)
> Any thoughts on this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (NUTCH-851) Port logging to slf4j
Posted by "Julien Nioche (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/NUTCH-851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Julien Nioche closed NUTCH-851.
-------------------------------
Resolution: Fixed
Committed revision 983885
> Port logging to slf4j
> ---------------------
>
> Key: NUTCH-851
> URL: https://issues.apache.org/jira/browse/NUTCH-851
> Project: Nutch
> Issue Type: New Feature
> Reporter: Julien Nioche
> Assignee: Julien Nioche
> Fix For: 2.0
>
> Attachments: NUTCH-851-v2.patch
>
>
> We are already inheriting a dependency on slf4j from Solr so we might as well use it :-)
> Any thoughts on this?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.