[GitHub] betodealmeida commented on a change in pull request #5695: [bugfix] geohash lat/long is reversed

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #5695: [bugfix] geohash lat/long is reversed
URL: https://github.com/apache/incubator-superset/pull/5695#discussion_r211826891
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -2113,17 +2121,13 @@ def process_spatial_data_obj(self, key, df):
         elif spatial.get('type') == 'delimited':
             lon_lat_col = spatial.get('lonlatCol')
             df[key] = df[lon_lat_col].apply(self.parse_coordinates)
-
             if spatial.get('reverseCheckbox'):
-                df[key] = [
-                    tuple(reversed(o)) if isinstance(o, (list, tuple)) else (0, 0)
 
 Review comment:
   I'm happy we're getting rid of the `(0, 0)` here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org