You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/13 15:57:04 UTC
[GitHub] [flink-ml] coderappee opened a new pull request, #109: [hotfix][flink-ml-lib][syntax]fix the forgotten static import method compareResultCollections from TestBaseUtils
coderappee opened a new pull request, #109:
URL: https://github.com/apache/flink-ml/pull/109
## What is the purpose of the change
- Fix syntax error not import the static method compareResultCollections from TestBaseUtils
## Brief change log
- *Just import the static method compareResultCollections from TestBaseUtils*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with @public(Evolving): (no)
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (Java doc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] coderappee commented on pull request #109: [hotfix][flink-ml-lib][syntax]fix the forgotten static import method compareResultCollections from TestBaseUtils
Posted by GitBox <gi...@apache.org>.
coderappee commented on PR #109:
URL: https://github.com/apache/flink-ml/pull/109#issuecomment-1156647134
> Hi @coderappee , thanks for creating this PR. Could you please illustrate why do we need to add these static imports? For now the test cases can still pass without these imports.
Ok, I understand that why I can not build the project and pass the test cases now, because I use the latest code of flink master and do not use flink version 1.15.0.
In or before flink version 1.15.0, AbstractTestBase is extended from TestBaseUtils, so any class extends from AbstractTestBase can use the static method of TestBaseUtils(compareResultCollections is one of the static method of it)
But after [FLINK-27454], the AbstractTestBase does not extend from TestBaseUtils any more.
It exteneds from TestLogger and can not use those static methods without static import.
Ok it depends whether we close this pr or not, since if we migrate or upgrade flink version newer than 1.15.0, we still need to static import that method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] yunfengzhou-hub commented on pull request #109: [hotfix][flink-ml-lib][syntax]fix the forgotten static import method compareResultCollections from TestBaseUtils
Posted by GitBox <gi...@apache.org>.
yunfengzhou-hub commented on PR #109:
URL: https://github.com/apache/flink-ml/pull/109#issuecomment-1157125976
Got it. From the information provided in [FLINK-27454](https://issues.apache.org/jira/browse/FLINK-27454) it seems that AbstractTestBase would still extend TestBaseUtils until flink 1.16.0. I think we could temporarily close this PR for now and re-visit it when Flink ML depends on newer versions of flink.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] yunfengzhou-hub commented on pull request #109: [hotfix][flink-ml-lib][syntax]fix the forgotten static import method compareResultCollections from TestBaseUtils
Posted by GitBox <gi...@apache.org>.
yunfengzhou-hub commented on PR #109:
URL: https://github.com/apache/flink-ml/pull/109#issuecomment-1156030528
Hi @coderappee , thanks for creating this PR. Could you please illustrate why do we need to add these static imports? For now the test cases can still pass without these imports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-ml] coderappee closed pull request #109: [hotfix][flink-ml-lib][syntax]fix the forgotten static import method compareResultCollections from TestBaseUtils
Posted by GitBox <gi...@apache.org>.
coderappee closed pull request #109: [hotfix][flink-ml-lib][syntax]fix the forgotten static import method compareResultCollections from TestBaseUtils
URL: https://github.com/apache/flink-ml/pull/109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org