[GitHub] [hadoop] bharatviswa504 commented on a change in pull request #804: HDDS-1496. Support partial chunk reads and checksum verification

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #804: HDDS-1496. Support partial chunk reads and checksum verification
URL: https://github.com/apache/hadoop/pull/804#discussion_r287051712
 
 

 ##########
 File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/KeyInputStream.java
 ##########
 @@ -53,58 +46,77 @@
 
   private static final int EOF = -1;
 
-  private final ArrayList<ChunkInputStreamEntry> streamEntries;
-  // streamOffset[i] stores the offset at which blockInputStream i stores
-  // data in the key
-  private long[] streamOffset = null;
-  private int currentStreamIndex;
+  private String key;
   private long length = 0;
   private boolean closed = false;
-  private String key;
 
-  public KeyInputStream() {
-    streamEntries = new ArrayList<>();
-    currentStreamIndex = 0;
-  }
+  // List of BlockInputStreams, one for each block in the key
+  private final List<BlockInputStream> blockStreams;
 
-  @VisibleForTesting
-  public synchronized int getCurrentStreamIndex() {
-    return currentStreamIndex;
-  }
+  // blockOffsets[i] stores the index of the first data byte in
+  // blockStream i w.r.t the key data.
 
 Review comment:
   Nit: i.e, or Unwanted i?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org