You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2015/07/31 12:59:58 UTC

[9/9] isis git commit: ISIS-1182: further tiny change to migration notes.

ISIS-1182: further tiny change to migration notes.


Project: http://git-wip-us.apache.org/repos/asf/isis/repo
Commit: http://git-wip-us.apache.org/repos/asf/isis/commit/59c3b494
Tree: http://git-wip-us.apache.org/repos/asf/isis/tree/59c3b494
Diff: http://git-wip-us.apache.org/repos/asf/isis/diff/59c3b494

Branch: refs/heads/master
Commit: 59c3b4942c9729260f09c1a27f4ad810628bdbbf
Parents: fabea33
Author: Dan Haywood <da...@haywood-associates.co.uk>
Authored: Fri Jul 31 11:59:35 2015 +0100
Committer: Dan Haywood <da...@haywood-associates.co.uk>
Committed: Fri Jul 31 11:59:35 2015 +0100

----------------------------------------------------------------------
 ...-notes_1.8.0-to-1.9.0_specify-all-dom-packages.adoc | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/isis/blob/59c3b494/adocs/documentation/src/main/asciidoc/_migration-notes_1.8.0-to-1.9.0_specify-all-dom-packages.adoc
----------------------------------------------------------------------
diff --git a/adocs/documentation/src/main/asciidoc/_migration-notes_1.8.0-to-1.9.0_specify-all-dom-packages.adoc b/adocs/documentation/src/main/asciidoc/_migration-notes_1.8.0-to-1.9.0_specify-all-dom-packages.adoc
index 88b1a05..0e09b41 100644
--- a/adocs/documentation/src/main/asciidoc/_migration-notes_1.8.0-to-1.9.0_specify-all-dom-packages.adoc
+++ b/adocs/documentation/src/main/asciidoc/_migration-notes_1.8.0-to-1.9.0_specify-all-dom-packages.adoc
@@ -18,7 +18,11 @@ Prior to 1.9.0 we used the link:https://github.com/ronmamo/reflections[Reflectio
 
 In 1.9.0 we have changed to using the link:https://github.com/lukehutch/fast-classpath-scanner[Fast-Classpath-Scanner] library, which is altogether more lightweight and has no dependencies.
 
-Generally this change should be transparent, however you should ensure that all domain classes are correctly registered using the `isis.persistor.datanucleus.RegisterEntities.packagePrefix` key.  This should include any domain classes for addon modules.
+Generally this change should be transparent, however there are two points to double-check.
+
+== Ensure dom classes registered
+
+First, you should ensure that all domain classes are correctly registered using the `isis.persistor.datanucleus.RegisterEntities.packagePrefix` key.  This should include any domain classes for addon modules.
 
 For example, the (non-ASF) http://github.com/isisaddons/isis-app-todoapp[Isis addons' todoapp]'s configuration now reads:
 
@@ -39,5 +43,10 @@ isis.persistor.datanucleus.RegisterEntities.packagePrefix=\
 Alternatively, could have just specified `org.isisaddons.module` instead of enumerating every addon.  This would be a bit slower, but more maintainable.
 ====
 
-
 If you fail to do this then DataNucleus will build up its metamodel lazily, rather than validate all classes up-front.  This can call issues: we've seen malformed SQL being submitted when DN wasn't aware of subclasses of a superclass, and we've also seen deadlocks when running against HSQLDB as it attempts to perform a DDL statement intermixed with DML statements.
+
+== Ensure services annotated
+
+In the previous implementation the xref:rg.adoc#_rg_annotations_manpage-DomainService[`@DomainService`] annotation could be applied to a superclass, and would be automatically picked up by any subclasses.
+
+With the new implementation this is no longer the case; every concrete domain service must be annotated with `@DomainService`.