You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/11/10 20:11:47 UTC
[GitHub] [phoenix] stoty commented on pull request #960: PHOENIX-6155 : Provide a coprocessor endpoint to avoid direct upserts into SYSTEM.TASK from the client
stoty commented on pull request #960:
URL: https://github.com/apache/phoenix/pull/960#issuecomment-724939657
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 5m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 3m 12s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 11m 35s | master passed |
| +1 :green_heart: | compile | 1m 23s | master passed |
| +1 :green_heart: | checkstyle | 5m 2s | master passed |
| +1 :green_heart: | javadoc | 1m 55s | master passed |
| +0 :ok: | spotbugs | 3m 7s | phoenix-core in master has 962 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 4m 6s | root in master has 1011 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 10s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 8m 52s | the patch passed |
| +1 :green_heart: | compile | 1m 24s | the patch passed |
| +1 :green_heart: | cc | 1m 24s | the patch passed |
| +1 :green_heart: | javac | 1m 24s | the patch passed |
| -1 :x: | checkstyle | 5m 6s | root: The patch generated 531 new + 16172 unchanged - 59 fixed = 16703 total (was 16231) |
| +1 :green_heart: | prototool | 0m 3s | There were no new prototool issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 1m 53s | the patch passed |
| -1 :x: | spotbugs | 3m 23s | phoenix-core generated 9 new + 962 unchanged - 0 fixed = 971 total (was 962) |
| -1 :x: | spotbugs | 4m 26s | root generated 9 new + 1011 unchanged - 0 fixed = 1020 total (was 1011) |
||| _ Other Tests _ |
| -1 :x: | unit | 155m 8s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 45s | The patch does not generate ASF License warnings. |
| | | 220m 1s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | org.apache.phoenix.coprocessor.generated.TaskMetaDataProtos$TaskMutateRequest.PARSER isn't final but should be At TaskMetaDataProtos.java:be At TaskMetaDataProtos.java:[line 114] |
| | Class org.apache.phoenix.coprocessor.generated.TaskMetaDataProtos$TaskMutateRequest defines non-transient non-serializable instance field unknownFields In TaskMetaDataProtos.java:instance field unknownFields In TaskMetaDataProtos.java |
| | Useless control flow in org.apache.phoenix.coprocessor.generated.TaskMetaDataProtos$TaskMutateRequest$Builder.maybeForceBuilderInitialization() At TaskMetaDataProtos.java: At TaskMetaDataProtos.java:[line 330] |
| | org.apache.phoenix.schema.task.SystemTaskParams.getEndTs() may expose internal representation by returning SystemTaskParams.endTs At SystemTaskParams.java:by returning SystemTaskParams.endTs At SystemTaskParams.java:[line 99] |
| | org.apache.phoenix.schema.task.SystemTaskParams.getStartTs() may expose internal representation by returning SystemTaskParams.startTs At SystemTaskParams.java:by returning SystemTaskParams.startTs At SystemTaskParams.java:[line 95] |
| | new org.apache.phoenix.schema.task.SystemTaskParams(PhoenixConnection, PTable$TaskType, String, String, String, String, String, Integer, Timestamp, Timestamp, boolean, boolean) may expose internal representation by storing an externally mutable object into SystemTaskParams.endTs At SystemTaskParams.java:String, String, String, Integer, Timestamp, Timestamp, boolean, boolean) may expose internal representation by storing an externally mutable object into SystemTaskParams.endTs At SystemTaskParams.java:[line 57] |
| | new org.apache.phoenix.schema.task.SystemTaskParams(PhoenixConnection, PTable$TaskType, String, String, String, String, String, Integer, Timestamp, Timestamp, boolean, boolean) may expose internal representation by storing an externally mutable object into SystemTaskParams.startTs At SystemTaskParams.java:String, String, String, Integer, Timestamp, Timestamp, boolean, boolean) may expose internal representation by storing an externally mutable object into SystemTaskParams.startTs At SystemTaskParams.java:[line 56] |
| | org.apache.phoenix.schema.task.SystemTaskParams$SystemTaskParamsBuilder.setEndTs(Timestamp) may expose internal representation by storing an externally mutable object into SystemTaskParams$SystemTaskParamsBuilder.endTs At SystemTaskParams.java:by storing an externally mutable object into SystemTaskParams$SystemTaskParamsBuilder.endTs At SystemTaskParams.java:[line 171] |
| | org.apache.phoenix.schema.task.SystemTaskParams$SystemTaskParamsBuilder.setStartTs(Timestamp) may expose internal representation by storing an externally mutable object into SystemTaskParams$SystemTaskParamsBuilder.startTs At SystemTaskParams.java:by storing an externally mutable object into SystemTaskParams$SystemTaskParamsBuilder.startTs At SystemTaskParams.java:[line 166] |
| FindBugs | module:root |
| | org.apache.phoenix.coprocessor.generated.TaskMetaDataProtos$TaskMutateRequest.PARSER isn't final but should be At TaskMetaDataProtos.java:be At TaskMetaDataProtos.java:[line 114] |
| | Class org.apache.phoenix.coprocessor.generated.TaskMetaDataProtos$TaskMutateRequest defines non-transient non-serializable instance field unknownFields In TaskMetaDataProtos.java:instance field unknownFields In TaskMetaDataProtos.java |
| | Useless control flow in org.apache.phoenix.coprocessor.generated.TaskMetaDataProtos$TaskMutateRequest$Builder.maybeForceBuilderInitialization() At TaskMetaDataProtos.java: At TaskMetaDataProtos.java:[line 330] |
| | org.apache.phoenix.schema.task.SystemTaskParams.getEndTs() may expose internal representation by returning SystemTaskParams.endTs At SystemTaskParams.java:by returning SystemTaskParams.endTs At SystemTaskParams.java:[line 99] |
| | org.apache.phoenix.schema.task.SystemTaskParams.getStartTs() may expose internal representation by returning SystemTaskParams.startTs At SystemTaskParams.java:by returning SystemTaskParams.startTs At SystemTaskParams.java:[line 95] |
| | new org.apache.phoenix.schema.task.SystemTaskParams(PhoenixConnection, PTable$TaskType, String, String, String, String, String, Integer, Timestamp, Timestamp, boolean, boolean) may expose internal representation by storing an externally mutable object into SystemTaskParams.endTs At SystemTaskParams.java:String, String, String, Integer, Timestamp, Timestamp, boolean, boolean) may expose internal representation by storing an externally mutable object into SystemTaskParams.endTs At SystemTaskParams.java:[line 57] |
| | new org.apache.phoenix.schema.task.SystemTaskParams(PhoenixConnection, PTable$TaskType, String, String, String, String, String, Integer, Timestamp, Timestamp, boolean, boolean) may expose internal representation by storing an externally mutable object into SystemTaskParams.startTs At SystemTaskParams.java:String, String, String, Integer, Timestamp, Timestamp, boolean, boolean) may expose internal representation by storing an externally mutable object into SystemTaskParams.startTs At SystemTaskParams.java:[line 56] |
| | org.apache.phoenix.schema.task.SystemTaskParams$SystemTaskParamsBuilder.setEndTs(Timestamp) may expose internal representation by storing an externally mutable object into SystemTaskParams$SystemTaskParamsBuilder.endTs At SystemTaskParams.java:by storing an externally mutable object into SystemTaskParams$SystemTaskParamsBuilder.endTs At SystemTaskParams.java:[line 171] |
| | org.apache.phoenix.schema.task.SystemTaskParams$SystemTaskParamsBuilder.setStartTs(Timestamp) may expose internal representation by storing an externally mutable object into SystemTaskParams$SystemTaskParamsBuilder.startTs At SystemTaskParams.java:by storing an externally mutable object into SystemTaskParams$SystemTaskParamsBuilder.startTs At SystemTaskParams.java:[line 166] |
| Failed junit tests | phoenix.end2end.ParameterizedIndexUpgradeToolIT |
| | phoenix.end2end.OrphanViewToolIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-960/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/960 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool |
| uname | Linux 4af925c8e842 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 28518ff |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-960/1/artifact/yetus-general-check/output/diff-checkstyle-root.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-960/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-960/1/artifact/yetus-general-check/output/new-spotbugs-root.html |
| unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-960/1/artifact/yetus-general-check/output/patch-unit-root.txt |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-960/1/testReport/ |
| Max. process+thread count | 6157 (vs. ulimit of 30000) |
| modules | C: phoenix-core . U: . |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-960/1/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 prototool=1.10.0-dev |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org