You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by andrewor14 <gi...@git.apache.org> on 2015/04/10 02:54:15 UTC

[GitHub] spark pull request: [SPARK-5719]allow daemons to bind to specified...

Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4505#discussion_r28116221
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/worker/WorkerArguments.scala ---
    @@ -23,46 +23,56 @@ import org.apache.spark.util.{IntParam, MemoryParam, Utils}
     import org.apache.spark.SparkConf
     
     /**
    - * Command-line parser for the worker.
    + * Arguments parser for the worker.
      */
     private[spark] class WorkerArguments(args: Array[String], conf: SparkConf) {
    -  var host = Utils.localHostName()
    -  var port = 0
    -  var webUiPort = 8081
    -  var cores = inferDefaultCores()
    -  var memory = inferDefaultMemory()
    +  var host: String = null
    +  var port: Int = -1
    +  var webUiPort: Int = -1
    +  var cores: Int = -1
    +  var memory: Int = -1
    --- End diff --
    
    ah I see


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org