[jira] [Commented] (ZOOKEEPER-1296) Add zookeeper-setup-conf.sh script

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-1296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147356#comment-13147356 ] 

Hadoop QA commented on ZOOKEEPER-1296:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12503140/ZOOKEEPER-1296.patch
  against trunk revision 1198053.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/784//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/784//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/784//console

This message is automatically generated.
                
> Add zookeeper-setup-conf.sh script
> ----------------------------------
>
>                 Key: ZOOKEEPER-1296
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1296
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 3.4.0
>         Environment: Shell script
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>            Priority: Minor
>         Attachments: ZOOKEEPER-1296.patch
>
>
> It would be nice to provide a setup script for zoo.cfg and zookeeper-env.sh.  The proposed script will provide the following options:
> {noformat}
> usage: /usr/sbin/zookeeper-setup-conf.sh <parameters>
>   Required parameters:
>     --conf-dir                     Set ZooKeeper configuration directory
>     --log-dir                      Set ZooKeeper log directory
>   Optional parameters:
>     --auto-purge-interval=1        Set snapshot auto purge interval
>     --client-port=2181             Set client port
>     --data-dir=/var/lib/zookeeper  Set data directory
>     --hosts=host1,host2            Set ZooKeeper qourum hostnames
>     --init-limit=10                Set initial sync limit
>     --java-home                    Set JAVA_HOME location
>     --snapshot-count=3             Set snapshot retain count
>     --sync-limit=5                 Set sync limit
>     --tick-time=2000               Set milliseconds of each tick
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira