You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/05/03 08:59:00 UTC
[jira] [Work logged] (HIVE-25082) Make updateTimezone a default
method on SettableTreeReader
[ https://issues.apache.org/jira/browse/HIVE-25082?focusedWorklogId=592083&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-592083 ]
ASF GitHub Bot logged work on HIVE-25082:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/May/21 08:58
Start Date: 03/May/21 08:58
Worklog Time Spent: 10m
Work Description: abstractdog commented on pull request #2236:
URL: https://github.com/apache/hive/pull/2236#issuecomment-831124035
I'm not 100% certain about this patch in this form, but I understand your intention
from the caller side, it's much cleaner to remove the cast, but from the interface side, it looks more like interface pollution, especially because we're adding a timestamp-only method to the interface, which is certainly not going to be implemented by most of the classes...I would like this as any of the 2 ways below:
1. doing the update in the setBuffers call like setBuffers(batch, sameStripe, stripeMetadata)
2. having a more general method on the interface instead of updateTimezone: anyNameYouWant(stripeMetadata) <- maybe we can reuse this method later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 592083)
Time Spent: 20m (was: 10m)
> Make updateTimezone a default method on SettableTreeReader
> ----------------------------------------------------------
>
> Key: HIVE-25082
> URL: https://issues.apache.org/jira/browse/HIVE-25082
> Project: Hive
> Issue Type: Improvement
> Reporter: Panagiotis Garefalakis
> Assignee: Panagiotis Garefalakis
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Avoid useless TimestampStreamReader instance checks by making updateTimezone() a default method in SettableTreeReader
--
This message was sent by Atlassian Jira
(v8.3.4#803005)