You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/09/17 01:53:40 UTC

[GitHub] rdhabalia opened a new pull request #2591: Fix: Compaction with last deleted keys not completing compaction

rdhabalia opened a new pull request #2591: Fix: Compaction with last deleted keys not completing compaction
URL: https://github.com/apache/incubator-pulsar/pull/2591
 
 
   ### Motivation
   
   Right now, topic-compaction ignores the message-id with empty payload but if the last message in the ledger has empty payload then compactor doesn't complete the compaction because compactor ignores last message and doesn't complete the result-future so, caller never sees complete result.
   
   ### Modifications
   
   - Compactor calculates` from` and `to` position for compacted ledger according to last non-deleted active key.
   - Compactor handles tail deleted keys from the ledger and completes compaction process gracefully.
   
   ### Result
   
   compactor can successfully compact ledger whose last message is also deleted.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services