You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2015/05/01 18:02:17 UTC

Review Request 33754: Update pthread autoconf macros for libprocess.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33754/
-----------------------------------------------------------

Review request for mesos.


Bugs: MESOS-2659
    https://issues.apache.org/jira/browse/MESOS-2659


Repository: mesos


Description
-------

Replace acx_pthread with ax_pthread. Update configure.ac to use the
new autoconf macros.


Diffs
-----

  3rdparty/libprocess/configure.ac c5106cd09901781ca77d8c02c73919553a085876 
  3rdparty/libprocess/m4/acx_pthread.m4 2cf20de144a11be2aa603b04ea511244191037b7 
  3rdparty/libprocess/m4/ax_pthread.m4 PRE-CREATION 

Diff: https://reviews.apache.org/r/33754/diff/


Testing
-------

Bootstrap and verify there are no autotools warnings. Tested on CentOS 7 and Mac OS X 10.10.3.


Thanks,

James Peach

Re: Review Request 33754: Update pthread autoconf macros for libprocess.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33754/#review82262
-----------------------------------------------------------


Patch looks great!

Reviews applied: [33754]

All tests passed.

- Mesos ReviewBot


On May 1, 2015, 4:02 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33754/
> -----------------------------------------------------------
> 
> (Updated May 1, 2015, 4:02 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2659
>     https://issues.apache.org/jira/browse/MESOS-2659
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replace acx_pthread with ax_pthread. Update configure.ac to use the
> new autoconf macros.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/configure.ac c5106cd09901781ca77d8c02c73919553a085876 
>   3rdparty/libprocess/m4/acx_pthread.m4 2cf20de144a11be2aa603b04ea511244191037b7 
>   3rdparty/libprocess/m4/ax_pthread.m4 PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33754/diff/
> 
> 
> Testing
> -------
> 
> Bootstrap and verify there are no autotools warnings. Tested on CentOS 7 and Mac OS X 10.10.3.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 33754: Update pthread autoconf macros for libprocess.

Posted by Benjamin Hindman <be...@berkeley.edu>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33754/#review86597
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On May 1, 2015, 4:02 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33754/
> -----------------------------------------------------------
> 
> (Updated May 1, 2015, 4:02 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2659
>     https://issues.apache.org/jira/browse/MESOS-2659
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replace acx_pthread with ax_pthread. Update configure.ac to use the
> new autoconf macros.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/configure.ac c5106cd09901781ca77d8c02c73919553a085876 
>   3rdparty/libprocess/m4/acx_pthread.m4 2cf20de144a11be2aa603b04ea511244191037b7 
>   3rdparty/libprocess/m4/ax_pthread.m4 PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33754/diff/
> 
> 
> Testing
> -------
> 
> Bootstrap and verify there are no autotools warnings. Tested on CentOS 7 and Mac OS X 10.10.3.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 33754: Update pthread autoconf macros for libprocess.

Posted by Benjamin Hindman <be...@berkeley.edu>.


> On May 18, 2015, 6:24 p.m., haosdent huang wrote:
> > 3rdparty/libprocess/configure.ac, line 745
> > <https://reviews.apache.org/r/33754/diff/1/?file=947259#file947259line745>
> >
> >     Maybe we could search the whole project and replace acx_pthread.m4 -> ax_pthread.m4

I fixed this for you before committing James, thanks!


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33754/#review84184
-----------------------------------------------------------


On May 1, 2015, 4:02 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33754/
> -----------------------------------------------------------
> 
> (Updated May 1, 2015, 4:02 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2659
>     https://issues.apache.org/jira/browse/MESOS-2659
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replace acx_pthread with ax_pthread. Update configure.ac to use the
> new autoconf macros.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/configure.ac c5106cd09901781ca77d8c02c73919553a085876 
>   3rdparty/libprocess/m4/acx_pthread.m4 2cf20de144a11be2aa603b04ea511244191037b7 
>   3rdparty/libprocess/m4/ax_pthread.m4 PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33754/diff/
> 
> 
> Testing
> -------
> 
> Bootstrap and verify there are no autotools warnings. Tested on CentOS 7 and Mac OS X 10.10.3.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 33754: Update pthread autoconf macros for libprocess.

Posted by haosdent huang <ha...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33754/#review84184
-----------------------------------------------------------



3rdparty/libprocess/configure.ac
<https://reviews.apache.org/r/33754/#comment135310>

    Maybe we could search the whole project and replace acx_pthread.m4 -> ax_pthread.m4


- haosdent huang


On May 1, 2015, 4:02 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33754/
> -----------------------------------------------------------
> 
> (Updated May 1, 2015, 4:02 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2659
>     https://issues.apache.org/jira/browse/MESOS-2659
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Replace acx_pthread with ax_pthread. Update configure.ac to use the
> new autoconf macros.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/configure.ac c5106cd09901781ca77d8c02c73919553a085876 
>   3rdparty/libprocess/m4/acx_pthread.m4 2cf20de144a11be2aa603b04ea511244191037b7 
>   3rdparty/libprocess/m4/ax_pthread.m4 PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33754/diff/
> 
> 
> Testing
> -------
> 
> Bootstrap and verify there are no autotools warnings. Tested on CentOS 7 and Mac OS X 10.10.3.
> 
> 
> Thanks,
> 
> James Peach
> 
>