[GitHub] [incubator-kvrocks] tisonkun commented on a diff in pull request #611: Update blob_file_size unit MiB to bytes.

[GitBox <gi...@apache.org>]

tisonkun commented on code in PR #611:
URL: https://github.com/apache/incubator-kvrocks/pull/611#discussion_r884190725


##########
kvrocks.conf:
##########
@@ -600,8 +600,8 @@ rocksdb.min_blob_size 4096
 # The size limit for blob files. When writing blob files, a new file is
 # opened once this limit is reached.
 #
-# Default: 256 MiB
-rocksdb.blob_file_size 256
+# Default: 268435456 byte

Review Comment:
   ```suggestion
   # Default: 268435456 bytes
   ```



##########
src/config.cc:
##########
@@ -449,26 +449,17 @@ void Config::initFieldCallback() {
       }},
       {"rocksdb.max_bytes_for_level_base", [this](Server* srv, const std::string &k, const std::string& v)->Status {
         if (!srv) return Status::OK();
-        if (!RocksDB.level_compaction_dynamic_level_bytes) {
-          return Status(Status::NotOK, errNotSetLevelCompactionDynamicLevelBytes);
-        }

Review Comment:
   Why do you make these changes?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org