You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2019/01/14 05:06:15 UTC
[GitHub] NamanRastogi commented on a change in pull request #3064:
[CARBONDATA-3243] Updated DOC for No-Sort Compaction and a few Fixes
NamanRastogi commented on a change in pull request #3064: [CARBONDATA-3243] Updated DOC for No-Sort Compaction and a few Fixes
URL: https://github.com/apache/carbondata/pull/3064#discussion_r247385555
##########
File path: processing/src/main/java/org/apache/carbondata/processing/sort/sortdata/SingleThreadFinalSortFilesMerger.java
##########
@@ -135,8 +135,8 @@ public void addInMemoryRawResultIterator(List<RawResultIterator> sortedRawResult
noDicAndComplexColumns, sortParameters, measureDataType);
if (inMemorySortTempChunkHolder.hasNext()) {
inMemorySortTempChunkHolder.readRow();
+ recordHolderHeapLocal.add(inMemorySortTempChunkHolder);
Review comment:
`inMemorySortTempChunkHolder` -> adapter for RawResultIterator on sorted files
`recordHolderHeapLocal` -> Priority Queue
This line adds `inMemorySortTempChunkHolder` to the `recordHolderHeapLocal` so that it can be used for final merge sorting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services