You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/11/12 07:39:57 UTC

[GitHub] [apisix-ingress-controller] nic-6443 edited a comment on pull request #745: feat: support environment variable in config file

nic-6443 edited a comment on pull request #745:
URL: https://github.com/apache/apisix-ingress-controller/pull/745#issuecomment-966889636


   > The code LGTM. Thanks!
   > 
   > But I personally prefer to directly support configuration through environment variables or through configuration files Instead of supporting environment variables in the configuration file.
   > 
   > WDYT? @gxthrj @tokers @lilien1010
   
   @tao12345666333  In the case that the user chooses to use file configuration instead of commands of container, the use of environment variables is to write sensitive information through downward api and secret.  So if the program directly uses env, we need to consider the problem of file configuration and env configuration merging,  doesn't make this problem easy.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org