You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/06/04 00:58:00 UTC
[jira] [Commented] (MINIFICPP-523) bootstrap.sh "continue"
confirmation prompt does n
[ https://issues.apache.org/jira/browse/MINIFICPP-523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16499625#comment-16499625 ]
ASF GitHub Bot commented on MINIFICPP-523:
------------------------------------------
GitHub user kevdoran opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/351
MINIFICPP-523 Fixes bootstrap continue with plan prompt
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kevdoran/nifi-minifi-cpp MINIFICPP-523-bootstrap
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/351.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #351
----
commit 76b4929ee50f188459fa562ec54fa83e73997c99
Author: Kevin Doran <kd...@...>
Date: 2018-06-04T00:55:30Z
MINIFICPP-523 Fixes bootstrap continue with plan prompt
----
> bootstrap.sh "continue" confirmation prompt does n
> --------------------------------------------------
>
> Key: MINIFICPP-523
> URL: https://issues.apache.org/jira/browse/MINIFICPP-523
> Project: NiFi MiNiFi C++
> Issue Type: Bug
> Affects Versions: 0.5.0
> Reporter: Kevin Doran
> Assignee: Kevin Doran
> Priority: Minor
>
> In bootstrap.sh, after options are selected and the bootstrap is complete, there is a confirmation prompt that displays the resulting cmake command and a Y/N to continue. Selecting N is ignored.
> It appears this is because the wrong variable is being checked in [bootstrap.sh#L534|https://github.com/apache/nifi-minifi-cpp/blob/e69b20aff3abe44be214d5edaf00e22a48258421/bootstrap.sh#L534]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)