[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1097: DISPATCH-2029: Added a base class and moved some of the http1 adaptor…

[GitBox <gi...@apache.org>]

jiridanek commented on a change in pull request #1097:
URL: https://github.com/apache/qpid-dispatch/pull/1097#discussion_r610396280



##########
File path: tests/CMakeLists.txt
##########
@@ -162,6 +162,7 @@ foreach(py_test_module
     system_tests_open_properties
     ${SYSTEM_TESTS_HTTP2}
     system_tests_http1_adaptor
+    system_tests_http1_over_tcp

Review comment:
       This test needs to be disabled on macOS, because it depends on raw-connections functionality in Proton. That's not available in the libuv proactor. I filled a Jira for it before I realized the test is simply incompatible with macOS https://issues.apache.org/jira/browse/DISPATCH-2042.
   
   Please add test name to
   
   https://github.com/apache/qpid-dispatch/blob/db30cb043bece740b5273b137057aa67b161ed50/.travis.yml#L139-L140




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org