[GitHub] [incubator-mxnet] mozga-intel edited a comment on pull request #20433: Clang-format tool to perform additional formatting and semantic checking of code.

[GitBox <gi...@apache.org>]

mozga-intel edited a comment on pull request #20433:
URL: https://github.com/apache/incubator-mxnet/pull/20433#issuecomment-881463020


   @leezu How about preparing a separate and specific-designed CI' job - we can call it lint_clang for clarity? It could be a CI' job with a single responsibility, responsible only for checking and keeping a code well-formatted. Inside, all checkers can be run: a clang-format and clang-tidy script for c++, a falke8 checker for python and so on.  It could be a fundamental basic property. A bash script with a single configuration - run this, this and this (either one script to run all checkers, or a few scripts to run one-dedicated)  However, a common theme running through this idea is a fundamental relationship that those things need to be placed in the same environment.
   
   I have one open questions to discuss: 
   - How the differences should be shown? - Either report it directly by showing that something went wrong or maybe it could be better to do it automatically behind a curtain. [Personally, I prefer to report any mistakes]


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org