You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/26 05:54:35 UTC

[GitHub] [shardingsphere] sandynz commented on a diff in pull request #21188: Refactor : refactor the github action workflow

sandynz commented on code in PR #21188:
URL: https://github.com/apache/shardingsphere/pull/21188#discussion_r979583188


##########
.github/workflows/ci.yml:
##########
@@ -77,11 +77,11 @@ jobs:
         uses: actions/cache@v2
         with:
           path: ~/.m2/repository
-          key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+          key: shardingsphere-it-cache-${{ github.sha }}

Review Comment:
   Maybe `hashFiles('**/pom.xml')` is better than `github.sha`, since `github.sha` is changed frequently, but `hashFiles('**/pom.xml')` might be not changed, so cache could be reused.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org