You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/26 10:45:54 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #4426: DB: fix wrong category id of guest os 'Other PV Virtio-SCSI (64-bit)'
ustcweizhou opened a new pull request #4426:
URL: https://github.com/apache/cloudstack/pull/4426
## Description
<!--- Describe your changes in detail -->
The guest os 'Other PV Virtio-SCSI (64-bit)' has category_id as 6 ("Windows"), which should be 7 ("Other").
```
mysql> select * from guest_os where id=275\G
*************************** 1. row ***************************
id: 275
category_id: 6
name: NULL
uuid: 5f080e85-c0fd-11ea-ba74-067606003392
display_name: Other PV Virtio-SCSI (64-bit)
created: 2020-07-08 09:28:24
removed: NULL
is_user_defined: 0
1 row in set (0.00 sec)
mysql> select * from guest_os_category;
+----+---------+--------------------------------------+
| id | name | uuid |
+----+---------+--------------------------------------+
| 1 | CentOS | 45bfdf47-c0fd-11ea-ba74-067606003392 |
| 2 | Debian | 45c0529b-c0fd-11ea-ba74-067606003392 |
| 3 | Oracle | 45c179a5-c0fd-11ea-ba74-067606003392 |
| 4 | RedHat | 45c1b328-c0fd-11ea-ba74-067606003392 |
| 5 | SUSE | 45c225de-c0fd-11ea-ba74-067606003392 |
| 6 | Windows | 45c254f2-c0fd-11ea-ba74-067606003392 |
| 7 | Other | 45c2be11-c0fd-11ea-ba74-067606003392 |
| 8 | Novel | 45c2efe7-c0fd-11ea-ba74-067606003392 |
| 9 | Unix | 45c35920-c0fd-11ea-ba74-067606003392 |
| 10 | Ubuntu | 45c387e4-c0fd-11ea-ba74-067606003392 |
| 11 | None | 45c3f75e-c0fd-11ea-ba74-067606003392 |
+----+---------+--------------------------------------+
11 rows in set (0.01 sec)
```
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4426: DB: fix wrong category id of guest os 'Other PV Virtio-SCSI (64-bit)'
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4426:
URL: https://github.com/apache/cloudstack/pull/4426#issuecomment-717847499
This change may affect users on upgraded, we may need to ask others for review @PaulAngus @DaanHoogland @wido @GabrielBrascher et al thnx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4426: DB: fix wrong category id of guest os 'Other PV Virtio-SCSI (64-bit)'
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4426:
URL: https://github.com/apache/cloudstack/pull/4426#issuecomment-717955434
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4426: DB: fix wrong category id of guest os 'Other PV Virtio-SCSI (64-bit)'
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4426:
URL: https://github.com/apache/cloudstack/pull/4426#issuecomment-718005874
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4426: DB: fix wrong category id of guest os 'Other PV Virtio-SCSI (64-bit)'
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4426:
URL: https://github.com/apache/cloudstack/pull/4426#issuecomment-717954916
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4426: DB: fix wrong category id of guest os 'Other PV Virtio-SCSI (64-bit)'
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4426:
URL: https://github.com/apache/cloudstack/pull/4426#issuecomment-717847046
@ustcweizhou can you fix the conflict?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #4426: DB: fix wrong category id of guest os 'Other PV Virtio-SCSI (64-bit)'
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged pull request #4426:
URL: https://github.com/apache/cloudstack/pull/4426
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache closed pull request #4426: DB: fix wrong category id of guest os 'Other PV Virtio-SCSI (64-bit)'
Posted by GitBox <gi...@apache.org>.
weizhouapache closed pull request #4426:
URL: https://github.com/apache/cloudstack/pull/4426
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4426: DB: fix wrong category id of guest os 'Other PV Virtio-SCSI (64-bit)'
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4426:
URL: https://github.com/apache/cloudstack/pull/4426#issuecomment-717855071
this is a good fix I don't see how it can hurt upgrades. templates that are `Other PV Virtio-SCSI (64-bit)` would now be deployed as `Windows` and should be `Other`. What is your concern, @rhtyd?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4426: DB: fix wrong category id of guest os 'Other PV Virtio-SCSI (64-bit)'
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4426:
URL: https://github.com/apache/cloudstack/pull/4426#issuecomment-718457555
bo failed to upload results: no regressions:
```
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Smoke tests completed. 86 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
```
merging
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4426: DB: fix wrong category id of guest os 'Other PV Virtio-SCSI (64-bit)'
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4426:
URL: https://github.com/apache/cloudstack/pull/4426#issuecomment-717990549
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2301
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4426: DB: fix wrong category id of guest os 'Other PV Virtio-SCSI (64-bit)'
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4426:
URL: https://github.com/apache/cloudstack/pull/4426#issuecomment-718006830
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org