You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by rxin <gi...@git.apache.org> on 2017/10/06 07:12:22 UTC
[GitHub] spark pull request #19250: [SPARK-12297] Table timezone correction for Times...
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19250#discussion_r143122317
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala ---
@@ -1213,6 +1213,71 @@ case class ToUTCTimestamp(left: Expression, right: Expression)
}
/**
+ * This modifies a timestamp to show how the display time changes going from one timezone to
+ * another, for the same instant in time.
+ *
+ * We intentionally do not provide an ExpressionDescription as this is not meant to be exposed to
+ * users, its only used for internal conversions.
+ */
+private[spark] case class TimestampTimezoneCorrection(
--- End diff --
do we need a whole expression for this? can't we just reuse existing expressions? It's just simple arithmetics isn't it?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org