You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/09 12:03:22 UTC
[GitHub] [camel-quarkus] jamesnetherton opened a new pull request #1766: Quarkus 1.8.0.final
jamesnetherton opened a new pull request #1766:
URL: https://github.com/apache/camel-quarkus/pull/1766
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1766: Quarkus 1.8.0.final
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1766:
URL: https://github.com/apache/camel-quarkus/pull/1766#discussion_r485628065
##########
File path: pom.xml
##########
@@ -75,7 +75,7 @@
<okhttp.version>3.14.6</okhttp.version><!-- keep in sync with okio -->
<okio.version>1.17.2</okio.version><!-- keep in sync with okhttp -->
<quarkus.version>1.8.0.Final</quarkus.version>
- <quarkus-qpid-jms.version>0.17.0</quarkus-qpid-jms.version>
+ <quarkus-qpid-jms.version>0.18.0</quarkus-qpid-jms.version>
Review comment:
Yes, we could do...
It would mean that we're perpetually dependent on the qpid folks to get their release out on time. If we didn't bump `quarkus-qpid-jms`, it's probably not a huge issue, unless there were breaking API changes in Quarkus. Then we'd definitely have to wait for their release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1766: Quarkus 1.8.0.final
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1766:
URL: https://github.com/apache/camel-quarkus/pull/1766#discussion_r485647916
##########
File path: pom.xml
##########
@@ -75,7 +75,7 @@
<okhttp.version>3.14.6</okhttp.version><!-- keep in sync with okio -->
<okio.version>1.17.2</okio.version><!-- keep in sync with okhttp -->
<quarkus.version>1.8.0.Final</quarkus.version>
- <quarkus-qpid-jms.version>0.17.0</quarkus-qpid-jms.version>
+ <quarkus-qpid-jms.version>0.18.0</quarkus-qpid-jms.version>
Review comment:
I'd be OK to consider it optional as long as their release is available. The main concern for me is not to forget to check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1766: Quarkus 1.8.0.final
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1766:
URL: https://github.com/apache/camel-quarkus/pull/1766#discussion_r485621107
##########
File path: pom.xml
##########
@@ -75,7 +75,7 @@
<okhttp.version>3.14.6</okhttp.version><!-- keep in sync with okio -->
<okio.version>1.17.2</okio.version><!-- keep in sync with okhttp -->
<quarkus.version>1.8.0.Final</quarkus.version>
- <quarkus-qpid-jms.version>0.17.0</quarkus-qpid-jms.version>
+ <quarkus-qpid-jms.version>0.18.0</quarkus-qpid-jms.version>
Review comment:
I wonder if we should not add this step to the release guide?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #1766: Quarkus 1.8.0.final
Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #1766:
URL: https://github.com/apache/camel-quarkus/pull/1766
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org