You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by Weibing Wang <ww...@apache.org> on 2022/11/22 12:02:37 UTC

[DISCUSS] Features to release with 1.4.0

Hi, brpc developers

Since brpc 1.3.0 has been released, let's talk about what feature to
release with 1.4.0
Any ideas?

Best Regards
Weibing

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


Re: [DISCUSS] Features to release with 1.4.0

Posted by Wang Xiaofeng <xi...@apache.org>.
Hi,

All features mentioned have been merged except this one:

- support channel option: health_check_path :
https://github.com/apache/brpc/pull/1806

which has been closed by the author. Maybe we can add this to the next release.

Regards,
Xiaofeng

On 2022/12/12 05:30:26 Weibing Wang wrote:
> The first three PRs have been merged, they will be included in version 1.4.0:
> 
> - Early return when size == 0 :
> https://github.com/apache/incubator-brpc/pull/2009
> - allow IOBuf::append_user_data_with_meta to specify the lkey of rdma
> memory region: https://github.com/apache/incubator-brpc/pull/2005
> - add bazel third_party support :
> https://github.com/apache/incubator-brpc/pull/1996
> 
> Best regards
> Weibing
> 
> On Thu, Nov 24, 2022 at 11:21 AM Weibing Wang <ww...@apache.org> wrote:
> >
> > Yes, the RDMA support should be included.
> > And I'd like the following feature to be included in 1.4.0:
> >
> > - Early return when size == 0 :
> > https://github.com/apache/incubator-brpc/pull/2009
> > - allow IOBuf::append_user_data_with_meta to specify the lkey of rdma
> > memory region: https://github.com/apache/incubator-brpc/pull/2005
> > - add bazel third_party support :
> > https://github.com/apache/incubator-brpc/pull/1996
> > - support channel option: health_check_path :
> > https://github.com/apache/incubator-brpc/pull/1806
> >
> > Best Regards
> > Weibing
> >
> > On Tue, Nov 22, 2022 at 8:13 PM Jerry Tan <je...@apache.org> wrote:
> > >
> > > RDMA support must be one feature,
> > > any more?
> > >
> > >
> > > On 2022/11/22 12:02:37 Weibing Wang wrote:
> > > > Hi, brpc developers
> > > >
> > > > Since brpc 1.3.0 has been released, let's talk about what feature to
> > > > release with 1.4.0
> > > > Any ideas?
> > > >
> > > > Best Regards
> > > > Weibing
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
> > > > For additional commands, e-mail: dev-help@brpc.apache.org
> > > >
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
> > > For additional commands, e-mail: dev-help@brpc.apache.org
> > >
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
> For additional commands, e-mail: dev-help@brpc.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


Re: [DISCUSS] Features to release with 1.4.0

Posted by Weibing Wang <ww...@apache.org>.
The first three PRs have been merged, they will be included in version 1.4.0:

- Early return when size == 0 :
https://github.com/apache/incubator-brpc/pull/2009
- allow IOBuf::append_user_data_with_meta to specify the lkey of rdma
memory region: https://github.com/apache/incubator-brpc/pull/2005
- add bazel third_party support :
https://github.com/apache/incubator-brpc/pull/1996

Best regards
Weibing

On Thu, Nov 24, 2022 at 11:21 AM Weibing Wang <ww...@apache.org> wrote:
>
> Yes, the RDMA support should be included.
> And I'd like the following feature to be included in 1.4.0:
>
> - Early return when size == 0 :
> https://github.com/apache/incubator-brpc/pull/2009
> - allow IOBuf::append_user_data_with_meta to specify the lkey of rdma
> memory region: https://github.com/apache/incubator-brpc/pull/2005
> - add bazel third_party support :
> https://github.com/apache/incubator-brpc/pull/1996
> - support channel option: health_check_path :
> https://github.com/apache/incubator-brpc/pull/1806
>
> Best Regards
> Weibing
>
> On Tue, Nov 22, 2022 at 8:13 PM Jerry Tan <je...@apache.org> wrote:
> >
> > RDMA support must be one feature,
> > any more?
> >
> >
> > On 2022/11/22 12:02:37 Weibing Wang wrote:
> > > Hi, brpc developers
> > >
> > > Since brpc 1.3.0 has been released, let's talk about what feature to
> > > release with 1.4.0
> > > Any ideas?
> > >
> > > Best Regards
> > > Weibing
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
> > > For additional commands, e-mail: dev-help@brpc.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
> > For additional commands, e-mail: dev-help@brpc.apache.org
> >

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


Re: [DISCUSS] Features to release with 1.4.0

Posted by Shuai Liu <se...@apache.org>.
I think this feature could be included in 1.4.0
- add timeout concurrency limiter:
https://github.com/apache/incubator-brpc/pull/2027/files

Best Regards,
serverglen


Weibing Wang <ww...@apache.org> 于2022年11月24日周四 11:21写道:

> Yes, the RDMA support should be included.
> And I'd like the following feature to be included in 1.4.0:
>
> - Early return when size == 0 :
> https://github.com/apache/incubator-brpc/pull/2009
> - allow IOBuf::append_user_data_with_meta to specify the lkey of rdma
> memory region: https://github.com/apache/incubator-brpc/pull/2005
> - add bazel third_party support :
> https://github.com/apache/incubator-brpc/pull/1996
> - support channel option: health_check_path :
> https://github.com/apache/incubator-brpc/pull/1806
>
> Best Regards
> Weibing
>
> On Tue, Nov 22, 2022 at 8:13 PM Jerry Tan <je...@apache.org> wrote:
> >
> > RDMA support must be one feature,
> > any more?
> >
> >
> > On 2022/11/22 12:02:37 Weibing Wang wrote:
> > > Hi, brpc developers
> > >
> > > Since brpc 1.3.0 has been released, let's talk about what feature to
> > > release with 1.4.0
> > > Any ideas?
> > >
> > > Best Regards
> > > Weibing
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
> > > For additional commands, e-mail: dev-help@brpc.apache.org
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
> > For additional commands, e-mail: dev-help@brpc.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
> For additional commands, e-mail: dev-help@brpc.apache.org
>
>

Re: [DISCUSS] Features to release with 1.4.0

Posted by Weibing Wang <ww...@apache.org>.
Yes, the RDMA support should be included.
And I'd like the following feature to be included in 1.4.0:

- Early return when size == 0 :
https://github.com/apache/incubator-brpc/pull/2009
- allow IOBuf::append_user_data_with_meta to specify the lkey of rdma
memory region: https://github.com/apache/incubator-brpc/pull/2005
- add bazel third_party support :
https://github.com/apache/incubator-brpc/pull/1996
- support channel option: health_check_path :
https://github.com/apache/incubator-brpc/pull/1806

Best Regards
Weibing

On Tue, Nov 22, 2022 at 8:13 PM Jerry Tan <je...@apache.org> wrote:
>
> RDMA support must be one feature,
> any more?
>
>
> On 2022/11/22 12:02:37 Weibing Wang wrote:
> > Hi, brpc developers
> >
> > Since brpc 1.3.0 has been released, let's talk about what feature to
> > release with 1.4.0
> > Any ideas?
> >
> > Best Regards
> > Weibing
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
> > For additional commands, e-mail: dev-help@brpc.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
> For additional commands, e-mail: dev-help@brpc.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org


Re: [DISCUSS] Features to release with 1.4.0

Posted by Jerry Tan <je...@apache.org>.
RDMA support must be one feature,
any more?


On 2022/11/22 12:02:37 Weibing Wang wrote:
> Hi, brpc developers
> 
> Since brpc 1.3.0 has been released, let's talk about what feature to
> release with 1.4.0
> Any ideas?
> 
> Best Regards
> Weibing
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
> For additional commands, e-mail: dev-help@brpc.apache.org
> 
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org