You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2023/01/17 11:15:19 UTC
[GitHub] [ozone] sodonnel opened a new pull request, #4183: HDDS-7788. Ratis OverReplicationHandler should exclude stale replicas
sodonnel opened a new pull request, #4183:
URL: https://github.com/apache/ozone/pull/4183
## What changes were proposed in this pull request?
As a stale DN is more than likely dead, in the RatisOverReplicationHandler we should exclude stale replicas before checking for over-replication. That way, we will not allow stale replicas to count toward over-replication. If we continue consider a stale replica as "present" for over-replication, we may remove another replica and then the stale one could go dead and get removed too, resulting in under replication.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7788
## How was this patch tested?
New unit test added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] siddhantsangwan commented on a diff in pull request #4183: HDDS-7788. Ratis OverReplicationHandler should exclude stale replicas
Posted by GitBox <gi...@apache.org>.
siddhantsangwan commented on code in PR #4183:
URL: https://github.com/apache/ozone/pull/4183#discussion_r1073282826
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/replication/TestRatisOverReplicationHandler.java:
##########
@@ -88,6 +95,24 @@ public void testOverReplicatedClosedContainer() throws IOException {
1);
}
+ /**
+ * Handler should create one delete command when a closed ratis container
+ * has 5 replicas and 1 pending delete.
+ */
Review Comment:
Description is incorrect for this test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sodonnel merged pull request #4183: HDDS-7788. Ratis OverReplicationHandler should exclude stale replicas
Posted by GitBox <gi...@apache.org>.
sodonnel merged PR #4183:
URL: https://github.com/apache/ozone/pull/4183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org