You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Till Rohrmann (JIRA)" <ji...@apache.org> on 2015/08/14 13:42:45 UTC
[jira] [Commented] (FLINK-2520) StreamFaultToleranceTestBase does
not allow for multiple tests
[ https://issues.apache.org/jira/browse/FLINK-2520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14696916#comment-14696916 ]
Till Rohrmann commented on FLINK-2520:
--------------------------------------
+1, this will also make test infrastructure refactorings much easier since one does not have to touch every test class.
> StreamFaultToleranceTestBase does not allow for multiple tests
> --------------------------------------------------------------
>
> Key: FLINK-2520
> URL: https://issues.apache.org/jira/browse/FLINK-2520
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 0.10
> Reporter: Stephan Ewen
> Priority: Minor
>
> It would be good to implement more tests into the same class (or user at least the same driver class), in order to re-use mini clusters and reducer overall test times.
> The {{StreamFaultToleranceTestBase}} does not support that.
> I think the pattern where the {{@Test}} methods are in a base class, and the actual tests only implement hook methods is not a good pattern.
> The batch API tests used this initially and we abandoned it everywhere for a more flexible implementation where the base class only sets up the. cluster/environment and the {{@Test}} methods go int the subclass.
> The {{MultipleProgramsTestBase}} is a good example of a flexible test base.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)