You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/26 21:15:03 UTC
[GitHub] [beam] caller9 opened a new pull request #12692: [BEAM-10819] Upgrade Gradle to 6.1.1
caller9 opened a new pull request #12692:
URL: https://github.com/apache/beam/pull/12692
This PR upgrades the Gradle build tool from 5.2.1 to 6.1.1.
Update build plugins to fix incompatibility:
org.nosphere.apache.rat:0.4.0 -> 0.5.2
com.diffplug.gradle.spotless:3.24.0 -> 3.24.2
net.ltgt.gradle:gradle-apt-plugin:0.20 -> 0.21
com.google.protobuf:protobuf-gradle-plugin:0.8.5 -> 0.8.8
Replace deprecated build scan with new version:
id 'com.gradle.build-scan' version '2.3'
moved from build.gradle to settings.gradle and switch to new plugin
id "com.gradle.enterprise" version "3.4.1"
Increase build JVM memory to 4GB.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @lukecwik`).
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [x] Update `CHANGES.md` with noteworthy changes.
- [x] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace
--- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #12692: [BEAM-10819] Upgrade Gradle to 6.1.1
Posted by GitBox <gi...@apache.org>.
kennknowles commented on pull request #12692:
URL: https://github.com/apache/beam/pull/12692#issuecomment-682072633
Java precommit looks like a flake in ML lib
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #12692: [BEAM-10819] Upgrade Gradle to 6.1.1
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #12692:
URL: https://github.com/apache/beam/pull/12692#issuecomment-690809163
Is this PR obsolete after https://github.com/apache/beam/pull/12776 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] caller9 closed pull request #12692: [BEAM-10819] Upgrade Gradle to 6.1.1
Posted by GitBox <gi...@apache.org>.
caller9 closed pull request #12692:
URL: https://github.com/apache/beam/pull/12692
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] runningcode commented on a change in pull request #12692: [BEAM-10819] Upgrade Gradle to 6.1.1
Posted by GitBox <gi...@apache.org>.
runningcode commented on a change in pull request #12692:
URL: https://github.com/apache/beam/pull/12692#discussion_r478602784
##########
File path: settings.gradle
##########
@@ -16,6 +16,16 @@
* limitations under the License.
*/
+plugins {
+ // Enable publishing build scans
+ id "com.gradle.enterprise" version "3.4.1" apply false
Review comment:
This is how the plugin is applied in Gradle 6.x. See the manual here: https://docs.gradle.com/enterprise/gradle-plugin/#applying_the_plugin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #12692: [BEAM-10819] Upgrade Gradle to 6.1.1
Posted by GitBox <gi...@apache.org>.
lukecwik commented on pull request #12692:
URL: https://github.com/apache/beam/pull/12692#issuecomment-682082691
This looks like we are duplicating effort from #12568
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on a change in pull request #12692: [BEAM-10819] Upgrade Gradle to 6.1.1
Posted by GitBox <gi...@apache.org>.
kennknowles commented on a change in pull request #12692:
URL: https://github.com/apache/beam/pull/12692#discussion_r478568021
##########
File path: settings.gradle
##########
@@ -16,6 +16,16 @@
* limitations under the License.
*/
+plugins {
+ // Enable publishing build scans
+ id "com.gradle.enterprise" version "3.4.1" apply false
Review comment:
Why does this move to settings.gradle?
##########
File path: gradle.properties
##########
@@ -30,3 +30,6 @@ javaVersion=1.8
docker_image_default_repo_root=apache
docker_image_default_repo_prefix=beam_
+#gcsProject=
+gcpProject=apache-beam-build
Review comment:
What is this? This is the cause of the Dataflow integration test failures. I don't think any of these changes should be necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] caller9 commented on pull request #12692: [BEAM-10819] Upgrade Gradle to 6.1.1
Posted by GitBox <gi...@apache.org>.
caller9 commented on pull request #12692:
URL: https://github.com/apache/beam/pull/12692#issuecomment-696301948
Obsolete after #12776
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] caller9 closed pull request #12692: [BEAM-10819] Upgrade Gradle to 6.1.1
Posted by GitBox <gi...@apache.org>.
caller9 closed pull request #12692:
URL: https://github.com/apache/beam/pull/12692
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #12692: [BEAM-10819] Upgrade Gradle to 6.1.1
Posted by GitBox <gi...@apache.org>.
lukecwik commented on pull request #12692:
URL: https://github.com/apache/beam/pull/12692#issuecomment-682081580
@kennknowles This change will likely need an equivalent update within Google to start using Gradle 6 as well. Please validate before merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #12692: [BEAM-10819] Upgrade Gradle to 6.1.1
Posted by GitBox <gi...@apache.org>.
lukecwik commented on pull request #12692:
URL: https://github.com/apache/beam/pull/12692#issuecomment-682104139
@kennknowles I will not have time to review this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] caller9 commented on pull request #12692: [BEAM-10819] Upgrade Gradle to 6.1.1
Posted by GitBox <gi...@apache.org>.
caller9 commented on pull request #12692:
URL: https://github.com/apache/beam/pull/12692#issuecomment-696301948
Obsolete after #12776
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org