You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/03/01 02:51:57 UTC

Re: Review Request: Properly cleanup cgroups.


> On Feb. 27, 2013, 6:43 p.m., Ben Mahler wrote:
> > src/slave/cgroups_isolation_module.cpp, line 946
> > <https://reviews.apache.org/r/9408/diff/12/?file=261997#file261997line946>
> >
> >     As a result of this NOTE it sounds like we should kill the sentinel values in favor of using Options, not expecting you to do that but maybe a TODO in the info struct if not already one present.

As the TODO notes the plan is to actually wait for the process terminated event, before informing the slave. So, need to make this sentinel.


- Vinod


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9408/#review17156
-----------------------------------------------------------


On Feb. 26, 2013, 12:32 a.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9408/
> -----------------------------------------------------------
> 
> (Updated Feb. 26, 2013, 12:32 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   src/slave/cgroups_isolation_module.hpp a04fc46b15d2741886f5847cadbdc9bed351c588 
>   src/slave/cgroups_isolation_module.cpp a779de80d13c67e507d7d2ee788fcdaa5e71daca 
>   src/slave/slave.hpp 7648c33230c1900eda7529045c5df9ccab105d47 
>   src/slave/slave.cpp 8c2e1bfc363491c681177676f9dfe5f229276f7d 
>   src/tests/balloon_framework_test.sh 93a733f64cfde08349b7781eb3d5e13594c74498 
> 
> Diff: https://reviews.apache.org/r/9408/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>