You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by mattyb149 <gi...@git.apache.org> on 2017/12/15 00:23:35 UTC

[GitHub] nifi pull request #2287: NIFI-4625 - Added External Version to the PutElasti...

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/2287#discussion_r157098024
  
    --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-5-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearch5.java ---
    @@ -129,6 +130,12 @@
                 .defaultValue("100")
                 .expressionLanguageSupported(true)
                 .build();
    +    
    +    public static final PropertyDescriptor VERSION_ATTRIBUTE = new PropertyDescriptor.Builder()
    +			.name("Version").displayName("Version Attribute")
    +			.description("The name of the attribute containing the version for each FlowFile. Only used for index operation. Forces External Versioning")
    +			.required(false).expressionLanguageSupported(false).addValidator(StandardValidators.ATTRIBUTE_KEY_VALIDATOR)
    --- End diff --
    
    That was an unfortunate oversight on my part, thinking you'd need a value for ID, and we've been a bit stuck with it ever since (until the next major version release perhaps). If the value is not required, then I think EL support should suffice?


---