Re: Review Request 15836: Fixed the master and slave main.cpp so that bad 'master|zk’ flags do not print a stack trace.

[Ben Mahler <be...@gmail.com>]

> On Nov. 25, 2013, 6:35 p.m., Ben Mahler wrote:
> > Ship It!

This is now committed, are you subscribed to commits@mesos.apache.org to receive commit notifications?


- Ben


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15836/#review29375
-----------------------------------------------------------


On Nov. 25, 2013, 6:31 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15836/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 6:31 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> 
> 
> Bugs: MESOS-826
>     https://issues.apache.org/jira/browse/MESOS-826
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/main.cpp 60c86b302206c652dd7108cee14c0d92fc0e3e07 
>   src/slave/main.cpp e83cd9e2892d1462db0d9110f076c3b81673075d 
> 
> Diff: https://reviews.apache.org/r/15836/diff/
> 
> 
> Testing
> -------
> 
> Manual:
> 
> $ ./bin/mesos-slave.sh --master=local
> I1125 18:28:09.402698 61542 main.cpp:118] Build: 2013-11-15 08:18:58 by jyx
> I1125 18:28:09.402796 61542 main.cpp:120] Creating "process" isolator
> Failed to create a master detector: Failed to parse 'local'
> $ ./bin/mesos-master.sh --zk=123
> I1125 18:28:31.557896 61635 main.cpp:126] Build: 2013-11-15 08:18:58 by jyx
> Failed to create a master contender: Failed to parse '123'
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>