You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Kyle Consalus (JIRA)" <ji...@apache.org> on 2011/09/19 22:30:09 UTC
[jira] [Created] (THRIFT-1350) Go library code does not build as of
r60 (most recent release)
Go library code does not build as of r60 (most recent release)
--------------------------------------------------------------
Key: THRIFT-1350
URL: https://issues.apache.org/jira/browse/THRIFT-1350
Project: Thrift
Issue Type: Bug
Components: Go - Library
Reporter: Kyle Consalus
Go has moved it's URL-handling code into a "url" package.
Also, strings.Split no longer takes a 3rd parameter.
Not sure how I attach a patch, but here's a diff:
http://pastie.org/2559636
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1350) Go library code does not build as
of r60 (most recent release)
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108286#comment-13108286 ]
Hudson commented on THRIFT-1350:
--------------------------------
Integrated in Thrift #268 (See [https://builds.apache.org/job/Thrift/268/])
THRIFT-1350: Go library code does not build against latest release
Client: go
Patch: Kyle Consalus
Go has moved it's URL-handling code into a "url" package, patch updates for these new changes.
jfarrell : http://svn.apache.org/viewvc/?view=rev&rev=1172901
Files :
* /thrift/trunk/lib/go/thrift/thttp_client.go
* /thrift/trunk/lib/go/thrift/tsimple_json_protocol_test.go
> Go library code does not build as of r60 (most recent release)
> --------------------------------------------------------------
>
> Key: THRIFT-1350
> URL: https://issues.apache.org/jira/browse/THRIFT-1350
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Reporter: Kyle Consalus
> Assignee: Kyle Consalus
> Fix For: 0.8
>
> Attachments: patch.diff
>
>
> Go has moved it's URL-handling code into a "url" package.
> Also, strings.Split no longer takes a 3rd parameter.
> Not sure how I attach a patch, but here's a diff:
> http://pastie.org/2559636
> Or, a simple run of "gofix" should probably handle it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1350) Go library code does not build as of
r60 (most recent release)
Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jake Farrell closed THRIFT-1350.
--------------------------------
Resolution: Fixed
Fix Version/s: 0.8
Assignee: Kyle Consalus
Thanks for the patch, committed
> Go library code does not build as of r60 (most recent release)
> --------------------------------------------------------------
>
> Key: THRIFT-1350
> URL: https://issues.apache.org/jira/browse/THRIFT-1350
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Reporter: Kyle Consalus
> Assignee: Kyle Consalus
> Fix For: 0.8
>
> Attachments: patch.diff
>
>
> Go has moved it's URL-handling code into a "url" package.
> Also, strings.Split no longer takes a 3rd parameter.
> Not sure how I attach a patch, but here's a diff:
> http://pastie.org/2559636
> Or, a simple run of "gofix" should probably handle it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1350) Go library code does not build as of
r60 (most recent release)
Posted by "Kyle Consalus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kyle Consalus updated THRIFT-1350:
----------------------------------
Attachment: patch.diff
Diff from head of trunk.
> Go library code does not build as of r60 (most recent release)
> --------------------------------------------------------------
>
> Key: THRIFT-1350
> URL: https://issues.apache.org/jira/browse/THRIFT-1350
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Reporter: Kyle Consalus
> Attachments: patch.diff
>
>
> Go has moved it's URL-handling code into a "url" package.
> Also, strings.Split no longer takes a 3rd parameter.
> Not sure how I attach a patch, but here's a diff:
> http://pastie.org/2559636
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1350) Go library code does not build as
of r60 (most recent release)
Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108193#comment-13108193 ]
Jake Farrell commented on THRIFT-1350:
--------------------------------------
Kyle, is this in the GO trunk or the latest released version of GO? We ran into a problem like this before where GO changed how they handled a library in their trunk version and broke compatibility with our current release. We opted to keep the driver current with the latest released version of GO and not their trunk. If this is latest released GO version I'll gladly add it. Thanks for the patch, if you have any questions about contributing please see http://wiki.apache.org/thrift/HowToContribute or feel free to email our dev mailing list with any questions at dev@thrift.apache.org
> Go library code does not build as of r60 (most recent release)
> --------------------------------------------------------------
>
> Key: THRIFT-1350
> URL: https://issues.apache.org/jira/browse/THRIFT-1350
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Reporter: Kyle Consalus
> Attachments: patch.diff
>
>
> Go has moved it's URL-handling code into a "url" package.
> Also, strings.Split no longer takes a 3rd parameter.
> Not sure how I attach a patch, but here's a diff:
> http://pastie.org/2559636
> Or, a simple run of "gofix" should probably handle it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1350) Go library code does not build as of
r60 (most recent release)
Posted by "Kyle Consalus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kyle Consalus updated THRIFT-1350:
----------------------------------
Description:
Go has moved it's URL-handling code into a "url" package.
Also, strings.Split no longer takes a 3rd parameter.
Not sure how I attach a patch, but here's a diff:
http://pastie.org/2559636
Or, a simple run of "gofix" should probably handle it.
was:
Go has moved it's URL-handling code into a "url" package.
Also, strings.Split no longer takes a 3rd parameter.
Not sure how I attach a patch, but here's a diff:
http://pastie.org/2559636
> Go library code does not build as of r60 (most recent release)
> --------------------------------------------------------------
>
> Key: THRIFT-1350
> URL: https://issues.apache.org/jira/browse/THRIFT-1350
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Reporter: Kyle Consalus
> Attachments: patch.diff
>
>
> Go has moved it's URL-handling code into a "url" package.
> Also, strings.Split no longer takes a 3rd parameter.
> Not sure how I attach a patch, but here's a diff:
> http://pastie.org/2559636
> Or, a simple run of "gofix" should probably handle it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1350) Go library code does not build as
of r60 (most recent release)
Posted by "Kyle Consalus (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108207#comment-13108207 ]
Kyle Consalus commented on THRIFT-1350:
---------------------------------------
Yep, this is for the newest release version, r60 (http://golang.org/doc/devel/release.html#r60)
And yes, good targeting releases is a good idea. That's what various distros will be carrying, what AppEngine runs, and what users are encouraged to use. Most breakages between releases can be fixed with a simple "gofix" tool that rewrites known changes.
> Go library code does not build as of r60 (most recent release)
> --------------------------------------------------------------
>
> Key: THRIFT-1350
> URL: https://issues.apache.org/jira/browse/THRIFT-1350
> Project: Thrift
> Issue Type: Bug
> Components: Go - Library
> Reporter: Kyle Consalus
> Attachments: patch.diff
>
>
> Go has moved it's URL-handling code into a "url" package.
> Also, strings.Split no longer takes a 3rd parameter.
> Not sure how I attach a patch, but here's a diff:
> http://pastie.org/2559636
> Or, a simple run of "gofix" should probably handle it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira