[GitHub] [incubator-superset] etr2460 commented on a change in pull request #12060: feat: View all fav charts and dashboards

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #12060:
URL: https://github.com/apache/incubator-superset/pull/12060#discussion_r543639391



##########
File path: superset-frontend/src/components/ListView/types.ts
##########
@@ -55,11 +55,14 @@ type FilterOperator =
   | 'all_text'
   | 'chart_all_text'
   | 'dataset_is_null_or_empty'
-  | 'between';
+  | 'between'
+  | 'dashboard_is_fav'
+  | 'chart_is_fav';

Review comment:
       I'd prefer that we don't abbreviate `favorite` throughout this PR, as using the full word is clearer, and with modern IDEs and autocomplete, it shouldn't make much of a difference either way. Thanks!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org