You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Chandan Purushothama <Ch...@citrix.com> on 2014/08/20 20:36:05 UTC
Re: Review Request 23986: Fixed 18 Test Case failures in
test_egress_fw_rules.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23986/
-----------------------------------------------------------
(Updated Aug. 20, 2014, 6:36 p.m.)
Review request for cloudstack, Doug Clark, Raja Pullela, Rayees Namathponnan, sanjeev n, Santhosh Edukulla, sudha ponnaganti, and SrikanteswaraRao Talluri.
Repository: cloudstack-git
Description (updated)
-------
18 Test cases in the "test_egress_fw_rules.py" script fails if the guest network is any network other than 10.1.1.0/24 network. The script assumes the guest network to be 10.1.1.0/24 network. Added code to the test suite so that the test cases will work for isolated guest network with any network cidr.
Reference Bug: https://issues.apache.org/jira/browse/CLOUDSTACK-7380
Diffs
-----
test/integration/component/test_egress_fw_rules.py 4b4b6ee
Diff: https://reviews.apache.org/r/23986/diff/
Testing (updated)
-------
Test By-default the communication from guest n/w to public n/w is NOT allowed. ... === TestName: test_01_1_egress_fr1 | Status : SUCCESS ===
ok
Test By-default the communication from guest n/w to public n/w is allowed. ... === TestName: test_01_egress_fr1 | Status : SUCCESS ===
ok
Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. ... === TestName: test_02_1_egress_fr2 | Status : SUCCESS ===
ok
Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. ... === TestName: test_02_egress_fr2 | Status : SUCCESS ===
ok
Test Communication blocked with network that is other than specified ... === TestName: test_03_1_egress_fr3 | Status : SUCCESS ===
ok
Test Communication blocked with network that is other than specified ... === TestName: test_03_egress_fr3 | Status : SUCCESS ===
ok
Test Create Egress rule and check the Firewall_Rules DB table ... === TestName: test_04_1_egress_fr4 | Status : SUCCESS ===
ok
Test Create Egress rule and check the Firewall_Rules DB table ... === TestName: test_04_egress_fr4 | Status : SUCCESS ===
ok
Test Create Egress rule and check the IP tables ... SKIP: Skip
Test Create Egress rule and check the IP tables ... SKIP: Skip
Test Create Egress rule without CIDR ... === TestName: test_06_1_egress_fr6 | Status : SUCCESS ===
ok
Test Create Egress rule without CIDR ... === TestName: test_06_egress_fr6 | Status : SUCCESS ===
ok
Test Create Egress rule without End Port ... === TestName: test_07_1_egress_fr7 | Status : SUCCESS ===
ok
Test Create Egress rule without End Port ... === TestName: test_07_egress_fr7 | Status : SUCCESS ===
ok
Test Port Forwarding and Egress Conflict ... SKIP: Skip
Test Port Forwarding and Egress Conflict ... SKIP: Skip
Test Delete Egress rule ... === TestName: test_09_1_egress_fr9 | Status : SUCCESS ===
ok
Test Delete Egress rule ... === TestName: test_09_egress_fr9 | Status : SUCCESS ===
ok
Test Invalid CIDR and Invalid Port ranges ... === TestName: test_10_1_egress_fr10 | Status : SUCCESS ===
ok
Test Invalid CIDR and Invalid Port ranges ... === TestName: test_10_egress_fr10 | Status : SUCCESS ===
ok
Test Regression on Firewall + PF + LB + SNAT ... === TestName: test_11_1_egress_fr11 | Status : SUCCESS ===
ok
Test Regression on Firewall + PF + LB + SNAT ... === TestName: test_11_egress_fr11 | Status : SUCCESS ===
ok
Test Reboot Router ... === TestName: test_12_1_egress_fr12 | Status : SUCCESS ===
ok
Test Reboot Router ... === TestName: test_12_egress_fr12 | Status : SUCCESS ===
ok
Test Redundant Router : Master failover ... === TestName: test_13_1_egress_fr13 | Status : SUCCESS ===
ok
Test Redundant Router : Master failover ... === TestName: test_13_egress_fr13 | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 26 tests in 35867.164s
OK (SKIP=4)
Thanks,
Chandan Purushothama
Re: Review Request 23986: Fixed 18 Test Case failures in
test_egress_fw_rules.py
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23986/#review51277
-----------------------------------------------------------
Ship it!
Ship It!
- Girish Shilamkar
On Aug. 20, 2014, 6:36 p.m., Chandan Purushothama wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23986/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2014, 6:36 p.m.)
>
>
> Review request for cloudstack, Doug Clark, Raja Pullela, Rayees Namathponnan, sanjeev n, Santhosh Edukulla, sudha ponnaganti, and SrikanteswaraRao Talluri.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 18 Test cases in the "test_egress_fw_rules.py" script fails if the guest network is any network other than 10.1.1.0/24 network. The script assumes the guest network to be 10.1.1.0/24 network. Added code to the test suite so that the test cases will work for isolated guest network with any network cidr.
>
> Reference Bug: https://issues.apache.org/jira/browse/CLOUDSTACK-7380
>
>
> Diffs
> -----
>
> test/integration/component/test_egress_fw_rules.py 4b4b6ee
>
> Diff: https://reviews.apache.org/r/23986/diff/
>
>
> Testing
> -------
>
> Test By-default the communication from guest n/w to public n/w is NOT allowed. ... === TestName: test_01_1_egress_fr1 | Status : SUCCESS ===
> ok
> Test By-default the communication from guest n/w to public n/w is allowed. ... === TestName: test_01_egress_fr1 | Status : SUCCESS ===
> ok
> Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. ... === TestName: test_02_1_egress_fr2 | Status : SUCCESS ===
> ok
> Test Allow Communication using Egress rule with CIDR + Port Range + Protocol. ... === TestName: test_02_egress_fr2 | Status : SUCCESS ===
> ok
> Test Communication blocked with network that is other than specified ... === TestName: test_03_1_egress_fr3 | Status : SUCCESS ===
> ok
> Test Communication blocked with network that is other than specified ... === TestName: test_03_egress_fr3 | Status : SUCCESS ===
> ok
> Test Create Egress rule and check the Firewall_Rules DB table ... === TestName: test_04_1_egress_fr4 | Status : SUCCESS ===
> ok
> Test Create Egress rule and check the Firewall_Rules DB table ... === TestName: test_04_egress_fr4 | Status : SUCCESS ===
> ok
> Test Create Egress rule and check the IP tables ... SKIP: Skip
> Test Create Egress rule and check the IP tables ... SKIP: Skip
> Test Create Egress rule without CIDR ... === TestName: test_06_1_egress_fr6 | Status : SUCCESS ===
> ok
> Test Create Egress rule without CIDR ... === TestName: test_06_egress_fr6 | Status : SUCCESS ===
> ok
> Test Create Egress rule without End Port ... === TestName: test_07_1_egress_fr7 | Status : SUCCESS ===
> ok
> Test Create Egress rule without End Port ... === TestName: test_07_egress_fr7 | Status : SUCCESS ===
> ok
> Test Port Forwarding and Egress Conflict ... SKIP: Skip
> Test Port Forwarding and Egress Conflict ... SKIP: Skip
> Test Delete Egress rule ... === TestName: test_09_1_egress_fr9 | Status : SUCCESS ===
> ok
> Test Delete Egress rule ... === TestName: test_09_egress_fr9 | Status : SUCCESS ===
> ok
> Test Invalid CIDR and Invalid Port ranges ... === TestName: test_10_1_egress_fr10 | Status : SUCCESS ===
> ok
> Test Invalid CIDR and Invalid Port ranges ... === TestName: test_10_egress_fr10 | Status : SUCCESS ===
> ok
> Test Regression on Firewall + PF + LB + SNAT ... === TestName: test_11_1_egress_fr11 | Status : SUCCESS ===
> ok
> Test Regression on Firewall + PF + LB + SNAT ... === TestName: test_11_egress_fr11 | Status : SUCCESS ===
> ok
> Test Reboot Router ... === TestName: test_12_1_egress_fr12 | Status : SUCCESS ===
> ok
> Test Reboot Router ... === TestName: test_12_egress_fr12 | Status : SUCCESS ===
> ok
> Test Redundant Router : Master failover ... === TestName: test_13_1_egress_fr13 | Status : SUCCESS ===
> ok
> Test Redundant Router : Master failover ... === TestName: test_13_egress_fr13 | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 26 tests in 35867.164s
>
> OK (SKIP=4)
>
>
> Thanks,
>
> Chandan Purushothama
>
>