You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by pabloem <gi...@git.apache.org> on 2017/07/07 20:59:08 UTC
[GitHub] beam pull request #3520: Improving labeling of side inputs for Dataflow
GitHub user pabloem opened a pull request:
https://github.com/apache/beam/pull/3520
Improving labeling of side inputs for Dataflow
Side inputs in Python show the internal step name on their user-visible label. This is not useful, and in fact undesirable as it also hides what kind of side input the pcollection is.
This improves the labeling of side inputs by showing the side input kind and pcollection in the label.
r: @robertwb
I have two questions regarding this change:
* A side input that is passed twice to the same ParDo may have problems here. But this may be a scenario that we want to discourage anyway. What do you think?
* I feel that the `'/Do' ` relabeling of the ParDo in line 525 could also be reconsidered to something more intuitive for the users (we've had bugs filed because users can't figure out which step owns their counters).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pabloem/incubator-beam python-silabel
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3520.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3520
----
commit 1c9e49e7b8d472b4e7bf08165a0755230432ab12
Author: Pablo <pa...@google.com>
Date: 2017-07-07T20:49:47Z
Improving labeling of side inputs for Dataflow
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] beam pull request #3520: Improving labeling of side inputs for Dataflow
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/3520
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---