[GitHub] [incubator-kyuubi] zwangsheng commented on a diff in pull request #3590: [KYUUBI #3385] Set spark.kubernetes.executor.podNamePrefix if missing

[GitBox <gi...@apache.org>]

zwangsheng commented on code in PR #3590:
URL: https://github.com/apache/incubator-kyuubi/pull/3590#discussion_r991789677


##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala:
##########
@@ -160,7 +160,9 @@ object SparkSQLEngine extends Logging {
       "20")
 
     val appName = s"kyuubi_${user}_spark_${Instant.now}"
+    val podNamePrefix = s"kyuubi_${user}_spark_sql"
     _sparkConf.setIfMissing("spark.app.name", appName)
+    _sparkConf.setIfMissing("spark.kubernetes.executor.podNamePrefix", podNamePrefix)

Review Comment:
   In kubernetes, same pod name is not supported. This may cause same user's another application can't scala up executor pod. How about add some uuid?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org