[GitHub] [streampipes] dominikriemer opened a new issue, #484: Fail to stop pipeline if one of the PE is stopped manually/not running

[GitBox <gi...@apache.org>]

dominikriemer opened a new issue, #484:
URL: https://github.com/apache/streampipes/issues/484

   I have identified a problem with the following use case.
   
   *Use case:*
   
   1) Run a pipeline with two flink PE's.
   
   2) Go to flink dashboard and cancel one of the flink job (i.e. PE)
   
   3) Go to streampipes UI and try to stop the pipeline.
   
   4) It fails to stop the pipeline completely because of the missing PE.
   
   5) The other PE's are stopped now, but the pipeline is still shown as running.
   
    
   
   *Expected behaviour:*
   
   If the flink job is not found, then it means that it is cancelled or failed. So streampipes should continue to stop this PE from its in-memory storage and mark the whole pipeline as Stopped.
   
    
   
   See the attached screenshots!
   
    
   Right now, I see two approaches: # Put the line 141 ([https://github.com/apache/incubator-streampipes/blob/2f10a17b77a93eee48527e4e88baf[…](https://github.com/apache/incubator-streampipes/blob/2f10a17b77a93eee48527e4e88baf[…)streampipes/container/api/InvocablePipelineElementResource.java|https://github.com/apache/incubator-streampipes/blob/2f10a17b77a93eee48527e4e88baf7e4b144d6fe/streampipes-container/src/main/java/org/apache/streampipes/container/api/InvocablePipelineElementResource.java#L141]) inside a try/catch block, and execute line 144 in any case.
    - Or, make a change in FlinkRuntime.java ([https://github.com/apache/incubator-streampipes/blob/2f10a17b77a93eee48527e4e88baf[…](https://github.com/apache/incubator-streampipes/blob/2f10a17b77a93eee48527e4e88baf[…)ain/java/org/apache/streampipes/wrapper/flink/FlinkRuntime.java|https://github.com/apache/incubator-streampipes/blob/2f10a17b77a93eee48527e4e88baf7e4b144d6fe/streampipes-wrapper-flink/src/main/java/org/apache/streampipes/wrapper/flink/FlinkRuntime.java#L264]) in method discardRuntime() to also check if its present and its state is running then cancel the job, else check if its status is CANCELLED or FAILED, then return and don't throw exception. Otherwise throw exception.
   
    
   
    
   
   Imported from Jira [STREAMPIPES-321](https://issues.apache.org/jira/browse/STREAMPIPES-321). Original Jira may contain additional context.
   Reported by: faizan-d.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [streampipes] dominikriemer closed issue #484: Fail to stop pipeline if one of the PE is stopped manually/not running

[GitBox <gi...@apache.org>]

dominikriemer closed issue #484: Fail to stop pipeline if one of the PE is stopped manually/not running
URL: https://github.com/apache/streampipes/issues/484


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org