You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/15 21:11:02 UTC
[GitHub] [tvm] mbrookhart opened a new pull request #7295: Fix an issue with dynamic functions overwritting call arg types
mbrookhart opened a new pull request #7295:
URL: https://github.com/apache/tvm/pull/7295
cc @jroesch @altanh @tmoreau89
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tmoreau89 merged pull request #7295: Fix an issue with dynamic functions overwritting call arg types
Posted by GitBox <gi...@apache.org>.
tmoreau89 merged pull request #7295:
URL: https://github.com/apache/tvm/pull/7295
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on pull request #7295: Fix an issue with dynamic functions overwritting call arg types
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #7295:
URL: https://github.com/apache/tvm/pull/7295#issuecomment-764917665
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tmoreau89 commented on pull request #7295: Fix an issue with dynamic functions overwritting call arg types
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #7295:
URL: https://github.com/apache/tvm/pull/7295#issuecomment-765022117
Thank you @mbrookhart and @altanh the PR has been merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on pull request #7295: Fix an issue with dynamic functions overwritting call arg types
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #7295:
URL: https://github.com/apache/tvm/pull/7295#issuecomment-764917665
@jroesch @tmoreau89 Hit a driver bug in a CI node last night than Tianqi fixed, otherwise this passed tests, I think it's ready for review while the rebase runs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tmoreau89 commented on pull request #7295: Fix an issue with dynamic functions overwritting call arg types
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #7295:
URL: https://github.com/apache/tvm/pull/7295#issuecomment-765022117
Thank you @mbrookhart and @altanh the PR has been merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on pull request #7295: Fix an issue with dynamic functions overwritting call arg types
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #7295:
URL: https://github.com/apache/tvm/pull/7295#issuecomment-765001735
Yes, my originally attempt failed a bunch prelude/adt tests because I didn't support that :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] mbrookhart commented on pull request #7295: Fix an issue with dynamic functions overwritting call arg types
Posted by GitBox <gi...@apache.org>.
mbrookhart commented on pull request #7295:
URL: https://github.com/apache/tvm/pull/7295#issuecomment-761220335
Yeah, it's a little weird. I'd like to run through CI just in case I introduced a bug somewhere, but once that's complete I can take a look at unifying the different versions of Unify.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tmoreau89 merged pull request #7295: Fix an issue with dynamic functions overwritting call arg types
Posted by GitBox <gi...@apache.org>.
tmoreau89 merged pull request #7295:
URL: https://github.com/apache/tvm/pull/7295
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] altanh commented on pull request #7295: Fix an issue with dynamic functions overwritting call arg types
Posted by GitBox <gi...@apache.org>.
altanh commented on pull request #7295:
URL: https://github.com/apache/tvm/pull/7295#issuecomment-761217256
not the fault of this PR, but I've noticed some confusing and inconsistent usage of `src` and `dst` in different `Unify` functions (along with non-matching implementation argument names). There might even be a slight bug where the order is exchanged in `TypeSolver` vs `TypeSolver::Unifier`, not sure if this affects correctness.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org