You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/04/08 07:36:00 UTC
[GitHub] [ignite] ibessonov opened a new pull request #7639: IGNITE-12438
Inverse TCP communication via Discovery implemented.
ibessonov opened a new pull request #7639: IGNITE-12438 Inverse TCP communication via Discovery implemented.
URL: https://github.com/apache/ignite/pull/7639
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] agoncharuk commented on a change in pull request #7639:
IGNITE-12438 Inverse TCP communication via Discovery implemented.
Posted by GitBox <gi...@apache.org>.
agoncharuk commented on a change in pull request #7639: IGNITE-12438 Inverse TCP communication via Discovery implemented.
URL: https://github.com/apache/ignite/pull/7639#discussion_r406691258
##########
File path: modules/core/src/main/java/org/apache/ignite/spi/communication/tcp/TcpCommunicationSpi.java
##########
@@ -2323,6 +2318,14 @@ private void dumpInfo(StringBuilder sb, UUID dstNodeId) {
throw new IgniteSpiException("Failed to initialize TCP server: " + locHost, e);
}
+ EnvironmentType envType = ignite.configuration().getEnvironmentType();
+
+ if (usePairedConnections) {
+ if (envType == EnvironmentType.VIRTUALIZED)
+ throw new IgniteSpiException("Node using paired connections " +
+ "is not allowed to start in virtualized environment.");
Review comment:
We need to suggest which configuration properties a user has to change in order to resolve this error
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] agoncharuk commented on a change in pull request #7639:
IGNITE-12438 Inverse TCP communication via Discovery implemented.
Posted by GitBox <gi...@apache.org>.
agoncharuk commented on a change in pull request #7639: IGNITE-12438 Inverse TCP communication via Discovery implemented.
URL: https://github.com/apache/ignite/pull/7639#discussion_r406797116
##########
File path: modules/core/src/main/java/org/apache/ignite/configuration/IgniteConfiguration.java
##########
@@ -3570,6 +3578,35 @@ public IgniteConfiguration setSqlSchemas(String... sqlSchemas) {
return this;
}
+ /**
+ * <b>This is an experimental feature. Envronment awareness approac may be changed.</b>
+ * <p>
+ *
+ * Configured environment type.
Review comment:
I suggest to expand javadoc here and describe that the environment type provides a hint to Ignite whether the Ignite instance is launched on a standalone machine or inside a virtualized environment. Describe what differences are important for virtualized environment (currently, NAT).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [ignite] agoncharuk commented on a change in pull request #7639:
IGNITE-12438 Inverse TCP communication via Discovery implemented.
Posted by GitBox <gi...@apache.org>.
agoncharuk commented on a change in pull request #7639: IGNITE-12438 Inverse TCP communication via Discovery implemented.
URL: https://github.com/apache/ignite/pull/7639#discussion_r406691455
##########
File path: modules/core/src/main/java/org/apache/ignite/spi/communication/tcp/TcpCommunicationSpi.java
##########
@@ -3491,6 +3500,19 @@ protected GridCommunicationClient createTcpClient(ClusterNode node, int connIdx)
* @throws IgniteCheckedException If establish connection fails.
*/
private GridNioSession createNioSession(ClusterNode node, int connIdx) throws IgniteCheckedException {
+ boolean locNodeIsSrv = !getLocalNode().isClient() && !getLocalNode().isDaemon();
+
+ if (!(Thread.currentThread() instanceof IgniteDiscoveryThread) && locNodeIsSrv) {
+ if (node.isClient() && startedInVirtualizedEnvironment(node)) {
+ String msg = "Failed to connect to node " + node.id() +
+ " because it is started n virtualized environment; inverse connection will be requested.";
Review comment:
Typo: n->in
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services