You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by borisroman <gi...@git.apache.org> on 2015/08/17 14:40:50 UTC
[GitHub] cloudstack pull request: Refactored NicProfile.java for readabilit...
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/705
Refactored NicProfile.java for readability.
Only changed names and reorganized them! No functional implementation change.
See issue CLOUDSTACK-8736 for ongoing effort to clean up network code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/borisroman/cloudstack CLOUDSTACK-8736
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/705.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #705
----
commit 5db337184057193001056f46e178836e6be2d6fd
Author: Boris Schrijver <bo...@pcextreme.nl>
Date: 2015-08-17T12:12:10Z
Refactored NicProfile.java for readability.
See issue CLOUDSTACK-8736 for ongoing effort to clean up network code.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Refactored NicProfile.java for readabilit...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/705#issuecomment-131808466
@DaanHoogland I did the following;
- Refactored NicProfile.java (in 1 go)
- Changed names in every file llinked to NicProfile to make sure no regression was in order.
How did you like more commits?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Refactored NicProfile.java for readabilit...
Posted by borisroman <gi...@git.apache.org>.
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/705#issuecomment-132115146
Hi @karuturi
The pull analysis failure is unrelated. --> Checkstyle errors in code I didn't touch
The errors in the master build are being caused by a change of method names as stated in the mail I send yesterday.
http://mail-archives.apache.org/mod_mbox/cloudstack-dev/201508.mbox/%3C1558679771.80.1439832860031.JavaMail.open-xchange%40109.72.87.221%3E
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Refactored NicProfile.java for readabilit...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/705#issuecomment-131810351
@borisroman first do internal restructure without changing the class interface and next change the accessors. never mind however don't do double work after I managed to review so I would need to do double work as well, let's find more support and merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Refactored NicProfile.java for readabilit...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/705
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Refactored NicProfile.java for readabilit...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/705#issuecomment-132076968
looks there are compilation errors in nuage plugin.
jenkins builds failed http://jenkins.buildacloud.org/job/build-master-noredist/4531/consoleText
http://jenkins.buildacloud.org/job/build-master-slowbuild/2086/consoleText
pull analysis also failed. but looks like a different reason.
https://builds.apache.org/job/cloudstack-pull-analysis/255/consoleText
@borisroman can you check if it is related to this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Refactored NicProfile.java for readabilit...
Posted by wido <gi...@git.apache.org>.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/705#issuecomment-131812682
Pending the checks LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Refactored NicProfile.java for readabilit...
Posted by DaanHoogland <gi...@git.apache.org>.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/705#issuecomment-131806145
:+1: this is one of the cases I would have liked to see more commits. lgtm in spite
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Refactored NicProfile.java for readabilit...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/705#issuecomment-132121809
ok. will check PR #707. Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---