You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/11/10 15:58:23 UTC

[GitHub] [pulsar] crossoverJie commented on pull request #18406: [fix][client] Fix possible npe

crossoverJie commented on PR #18406:
URL: https://github.com/apache/pulsar/pull/18406#issuecomment-1310515080

   > I second @eolivelli that `scheduleAtFixedRate` should keep the submitted task executed individually. That is, before the current `checkRequestTimeout` returns, there's no new execution to `checkRequestTimeout` when be triggered.
   
   You're right.
   
   `io.netty.util.concurrent.EventExecutorGroup#scheduleAtFixedRate`
   `java.util.concurrent.ScheduledExecutorService#scheduleAtFixedRate`
   
   After testing, I found that netty's implementation is not the same as JDK, only one thread is running.
   
   But in other words, in the context of concurrent programming specifications and static scanning of code, I think NPE checking should also be necessary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org