You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by "gansheer (via GitHub)" <gi...@apache.org> on 2023/10/03 09:06:21 UTC

[PR] fix(e2e): Add installation with helm,kustomize,olm securityContext re… [camel-k]

gansheer opened a new pull request, #4787:
URL: https://github.com/apache/camel-k/pull/4787

   Fix #4786 
   
   ## Description
   
   Add e2e tests installation with helm,kustomize,olm securityContext restricted validation
   
   <!-- Description -->
   
   
   
   
   <!--
   Enter your extended release note in the below block. If the PR requires
   additional action from users switching to the new release, include the string
   "action required". If no release note is required, write "NONE". 
   
   You can (optionally) mark this PR with labels "kind/bug" or "kind/feature" to make sure
   the text is added to the right section of the release notes. 
   -->
   
   **Release Note**
   ```release-note
   fix(e2e): Add installation with helm,kustomize,olm securityContext restricted
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(e2e): Add installation with helm,kustomize,olm securityContext re… [camel-k]

Posted by "gansheer (via GitHub)" <gi...@apache.org>.

gansheer commented on PR #4787:
URL: https://github.com/apache/camel-k/pull/4787#issuecomment-1746299732

   > @gansheer can you please confirm if you're finally going to address the reflection or can I merge this the way it is? Thanks!
   
   I knew I forgot something :sweat_smile: . Yes I am taking care of it and will fix the CLI test as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(e2e): Add installation with helm,kustomize,olm securityContext re… [camel-k]

Posted by "squakez (via GitHub)" <gi...@apache.org>.

squakez commented on PR #4787:
URL: https://github.com/apache/camel-k/pull/4787#issuecomment-1746288320

   @gansheer can you please confirm if you're finally going to address the reflection or can I merge this the way it is? Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(e2e): Add installation with helm,kustomize,olm securityContext re… [camel-k]

Posted by "squakez (via GitHub)" <gi...@apache.org>.

squakez merged PR #4787:
URL: https://github.com/apache/camel-k/pull/4787


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(e2e): Add installation with helm,kustomize,olm securityContext re… [camel-k]

Posted by "gansheer (via GitHub)" <gi...@apache.org>.

gansheer commented on PR #4787:
URL: https://github.com/apache/camel-k/pull/4787#issuecomment-1744799130

   > Looks good. However, in general, I'd avoid to introduce reflection.
   
   Noted. Do you want me to change the current PR ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix(e2e): Add installation with helm,kustomize,olm securityContext re… [camel-k]

Posted by "squakez (via GitHub)" <gi...@apache.org>.

squakez commented on PR #4787:
URL: https://github.com/apache/camel-k/pull/4787#issuecomment-1744903637

   @gansheer as you prefer. If it's not that much effort, maybe it is a good idea to avoid adding reflection and managing later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org