You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/04/11 18:47:06 UTC
[GitHub] [incubator-pekko-persistence-r2dbc] mdedetrich opened a new pull request, #10: Update sbt header
mdedetrich opened a new pull request, #10:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/10
Does the following
* Adds required headers to all source files
* Updates the sbt-header check to make sure headers are correct
* Adds github action status check to make sure headers are working
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-r2dbc] pjfanning commented on a diff in pull request #10: Update sbt header
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #10:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/10#discussion_r1163212619
##########
project/AutomaticModuleName.scala:
##########
@@ -1,6 +1,7 @@
/**
* Copyright (C) 2009-2018 Lightbend Inc. <http://www.lightbend.com>
*/
+
Review Comment:
could you manually add an Apache header to these project files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-r2dbc] mdedetrich commented on a diff in pull request #10: Update sbt header
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #10:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/10#discussion_r1163215179
##########
project/AutomaticModuleName.scala:
##########
@@ -1,6 +1,7 @@
/**
* Copyright (C) 2009-2018 Lightbend Inc. <http://www.lightbend.com>
*/
+
Review Comment:
Done and force pushed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-r2dbc] He-Pin merged pull request #10: Update sbt header
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #10:
URL: https://github.com/apache/incubator-pekko-persistence-r2dbc/pull/10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org