You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/06/26 17:06:16 UTC
Review Request 35925: Ambari RU doesn't work with Redhat satellite
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35925/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
Bugs: AMBARI-12169
https://issues.apache.org/jira/browse/AMBARI-12169
Repository: ambari
Description
-------
PROBLEM: If the regular repository is not used, set up RH satellite and subscribed to some particular channel for yum install, there is not repo file under /etc/yum.repos.d/, and nothing can be put into the repository url in Ambari. This can be workaround, but when ambari doing the RU, the command is:
/usr/bin/yum -d 0 -e 0 -y install '--disablerepo=*' --enablerepo=base,HDP-UTILS-2.2.4.2,HDP-2.2.4.2 'hadoop_2_2_*'
This will disable all the repository channels in the RH satellite. So the install will fail.
After the patch all the packages are installed like
2015-06-26 12:05:50,951 - Package['hadoop_2_2_*'] {'use_repos': ['HDP-2.2.6.0-2799', 'HDP-UTILS-2.2.6.0-2799']}
2015-06-26 12:05:50,952 - Installing package hadoop_2_2_* ('/usr/bin/yum -d 0 -e 0 -y install '--disablerepo=HDP*' --enablerepo=HDP-2.2.6.0-2799,HDP-UTILS-2.2.6.0-2799 'hadoop_2_2_*'')
Diffs
-----
ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py c17b7f0
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 0681afe
ambari-server/src/test/python/custom_actions/TestInstallPackages.py 6badfd1
Diff: https://reviews.apache.org/r/35925/diff/
Testing
-------
----------------------------------------------------------------------
Ran 268 tests in 8.991s
OK
----------------------------------------------------------------------
Total run:797
Total errors:0
Total failures:0
OK
Thanks,
Dmytro Sen
Re: Review Request 35925: Ambari RU doesn't work with Redhat satellite
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35925/
-----------------------------------------------------------
(Updated Июнь 26, 2015, 5:10 п.п.)
Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
Bugs: AMBARI-12169
https://issues.apache.org/jira/browse/AMBARI-12169
Repository: ambari
Description
-------
PROBLEM: If the regular repository is not used, set up RH satellite and subscribed to some particular channel for yum install, there is not repo file under /etc/yum.repos.d/, and nothing can be put into the repository url in Ambari. This can be workaround, but when ambari doing the RU, the command is:
/usr/bin/yum -d 0 -e 0 -y install '--disablerepo=*' --enablerepo=base,HDP-UTILS-2.2.4.2,HDP-2.2.4.2 'hadoop_2_2_*'
This will disable all the repository channels in the RH satellite. So the install will fail.
After the patch all the packages are installed like
2015-06-26 12:05:50,951 - Package['hadoop_2_2_*'] {'use_repos': ['HDP-2.2.6.0-2799', 'HDP-UTILS-2.2.6.0-2799']}
2015-06-26 12:05:50,952 - Installing package hadoop_2_2_* ('/usr/bin/yum -d 0 -e 0 -y install '--disablerepo=HDP*' --enablerepo=HDP-2.2.6.0-2799,HDP-UTILS-2.2.6.0-2799 'hadoop_2_2_*'')
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/core/providers/package/__init__.py ad48b43
ambari-common/src/main/python/resource_management/core/providers/package/apt.py c4cae2a
ambari-common/src/main/python/resource_management/core/providers/package/choco.py cd345fa
ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py c17b7f0
ambari-common/src/main/python/resource_management/core/providers/package/zypper.py dd16ce0
ambari-common/src/main/python/resource_management/core/resources/packaging.py 4e8c9fc
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostStackVersionResourceProvider.java a44be9a
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 0681afe
ambari-server/src/test/python/custom_actions/TestInstallPackages.py 6badfd1
Diff: https://reviews.apache.org/r/35925/diff/
Testing
-------
----------------------------------------------------------------------
Ran 268 tests in 8.991s
OK
----------------------------------------------------------------------
Total run:797
Total errors:0
Total failures:0
OK
Thanks,
Dmytro Sen
Re: Review Request 35925: Ambari RU doesn't work with Redhat satellite
Posted by Nate Cole <nc...@hortonworks.com>.
> On June 26, 2015, 11:26 a.m., Nate Cole wrote:
> > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py, line 91
> > <https://reviews.apache.org/r/35925/diff/1/?file=993008#file993008line91>
> >
> > If we exclude HDP*, and include HDP-<version>, do we need to specifically say "base" here?
>
> Dmytro Sen wrote:
> That's a patch for RH, shouldn't we say 'base' for sles/ubuntu ?
Not sure about those platforms. I don't know if "base" applies to sles/ubuntu. If you find out, you can drop.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35925/#review89502
-----------------------------------------------------------
On June 26, 2015, 11:06 a.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35925/
> -----------------------------------------------------------
>
> (Updated June 26, 2015, 11:06 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
>
>
> Bugs: AMBARI-12169
> https://issues.apache.org/jira/browse/AMBARI-12169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM: If the regular repository is not used, set up RH satellite and subscribed to some particular channel for yum install, there is not repo file under /etc/yum.repos.d/, and nothing can be put into the repository url in Ambari. This can be workaround, but when ambari doing the RU, the command is:
> /usr/bin/yum -d 0 -e 0 -y install '--disablerepo=*' --enablerepo=base,HDP-UTILS-2.2.4.2,HDP-2.2.4.2 'hadoop_2_2_*'
> This will disable all the repository channels in the RH satellite. So the install will fail.
>
> After the patch all the packages are installed like
>
> 2015-06-26 12:05:50,951 - Package['hadoop_2_2_*'] {'use_repos': ['HDP-2.2.6.0-2799', 'HDP-UTILS-2.2.6.0-2799']}
> 2015-06-26 12:05:50,952 - Installing package hadoop_2_2_* ('/usr/bin/yum -d 0 -e 0 -y install '--disablerepo=HDP*' --enablerepo=HDP-2.2.6.0-2799,HDP-UTILS-2.2.6.0-2799 'hadoop_2_2_*'')
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py c17b7f0
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 0681afe
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 6badfd1
>
> Diff: https://reviews.apache.org/r/35925/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 268 tests in 8.991s
>
> OK
> ----------------------------------------------------------------------
> Total run:797
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 35925: Ambari RU doesn't work with Redhat satellite
Posted by Dmytro Sen <ds...@hortonworks.com>.
> On Июнь 26, 2015, 3:26 п.п., Nate Cole wrote:
> > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py, line 91
> > <https://reviews.apache.org/r/35925/diff/1/?file=993008#file993008line91>
> >
> > If we exclude HDP*, and include HDP-<version>, do we need to specifically say "base" here?
That's a patch for RH, shouldn't we say 'base' for sles/ubuntu ?
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35925/#review89502
-----------------------------------------------------------
On Июнь 26, 2015, 3:06 п.п., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35925/
> -----------------------------------------------------------
>
> (Updated Июнь 26, 2015, 3:06 п.п.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
>
>
> Bugs: AMBARI-12169
> https://issues.apache.org/jira/browse/AMBARI-12169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM: If the regular repository is not used, set up RH satellite and subscribed to some particular channel for yum install, there is not repo file under /etc/yum.repos.d/, and nothing can be put into the repository url in Ambari. This can be workaround, but when ambari doing the RU, the command is:
> /usr/bin/yum -d 0 -e 0 -y install '--disablerepo=*' --enablerepo=base,HDP-UTILS-2.2.4.2,HDP-2.2.4.2 'hadoop_2_2_*'
> This will disable all the repository channels in the RH satellite. So the install will fail.
>
> After the patch all the packages are installed like
>
> 2015-06-26 12:05:50,951 - Package['hadoop_2_2_*'] {'use_repos': ['HDP-2.2.6.0-2799', 'HDP-UTILS-2.2.6.0-2799']}
> 2015-06-26 12:05:50,952 - Installing package hadoop_2_2_* ('/usr/bin/yum -d 0 -e 0 -y install '--disablerepo=HDP*' --enablerepo=HDP-2.2.6.0-2799,HDP-UTILS-2.2.6.0-2799 'hadoop_2_2_*'')
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py c17b7f0
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 0681afe
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 6badfd1
>
> Diff: https://reviews.apache.org/r/35925/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 268 tests in 8.991s
>
> OK
> ----------------------------------------------------------------------
> Total run:797
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 35925: Ambari RU doesn't work with Redhat satellite
Posted by Dmytro Sen <ds...@hortonworks.com>.
> On Июнь 26, 2015, 3:26 п.п., Nate Cole wrote:
> > ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py, lines 45-46
> > <https://reviews.apache.org/r/35925/diff/1/?file=993007#file993007line45>
> >
> > I think we should modify the Package "abstract class" to support an ignore_repos (or skip_repos or whatever) argument. That way we're not constantly chasing this particular line (this is the 3rd time) and we can pass it in the arguments like we do with use_repos.
disablerepo option is used only by yumrpm.py and only with value HDP*
Lets create a separate task for that for Ambari 2.2.0 ?
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35925/#review89502
-----------------------------------------------------------
On Июнь 26, 2015, 3:06 п.п., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35925/
> -----------------------------------------------------------
>
> (Updated Июнь 26, 2015, 3:06 п.п.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
>
>
> Bugs: AMBARI-12169
> https://issues.apache.org/jira/browse/AMBARI-12169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM: If the regular repository is not used, set up RH satellite and subscribed to some particular channel for yum install, there is not repo file under /etc/yum.repos.d/, and nothing can be put into the repository url in Ambari. This can be workaround, but when ambari doing the RU, the command is:
> /usr/bin/yum -d 0 -e 0 -y install '--disablerepo=*' --enablerepo=base,HDP-UTILS-2.2.4.2,HDP-2.2.4.2 'hadoop_2_2_*'
> This will disable all the repository channels in the RH satellite. So the install will fail.
>
> After the patch all the packages are installed like
>
> 2015-06-26 12:05:50,951 - Package['hadoop_2_2_*'] {'use_repos': ['HDP-2.2.6.0-2799', 'HDP-UTILS-2.2.6.0-2799']}
> 2015-06-26 12:05:50,952 - Installing package hadoop_2_2_* ('/usr/bin/yum -d 0 -e 0 -y install '--disablerepo=HDP*' --enablerepo=HDP-2.2.6.0-2799,HDP-UTILS-2.2.6.0-2799 'hadoop_2_2_*'')
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py c17b7f0
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 0681afe
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 6badfd1
>
> Diff: https://reviews.apache.org/r/35925/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 268 tests in 8.991s
>
> OK
> ----------------------------------------------------------------------
> Total run:797
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 35925: Ambari RU doesn't work with Redhat satellite
Posted by Dmytro Sen <ds...@hortonworks.com>.
> On Июнь 26, 2015, 3:26 п.п., Nate Cole wrote:
> > ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py, lines 45-46
> > <https://reviews.apache.org/r/35925/diff/1/?file=993007#file993007line45>
> >
> > I think we should modify the Package "abstract class" to support an ignore_repos (or skip_repos or whatever) argument. That way we're not constantly chasing this particular line (this is the 3rd time) and we can pass it in the arguments like we do with use_repos.
>
> Dmytro Sen wrote:
> disablerepo option is used only by yumrpm.py and only with value HDP*
> Lets create a separate task for that for Ambari 2.2.0 ?
But, yes, we will have another value for non-HDP stacks
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35925/#review89502
-----------------------------------------------------------
On Июнь 26, 2015, 3:06 п.п., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35925/
> -----------------------------------------------------------
>
> (Updated Июнь 26, 2015, 3:06 п.п.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
>
>
> Bugs: AMBARI-12169
> https://issues.apache.org/jira/browse/AMBARI-12169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM: If the regular repository is not used, set up RH satellite and subscribed to some particular channel for yum install, there is not repo file under /etc/yum.repos.d/, and nothing can be put into the repository url in Ambari. This can be workaround, but when ambari doing the RU, the command is:
> /usr/bin/yum -d 0 -e 0 -y install '--disablerepo=*' --enablerepo=base,HDP-UTILS-2.2.4.2,HDP-2.2.4.2 'hadoop_2_2_*'
> This will disable all the repository channels in the RH satellite. So the install will fail.
>
> After the patch all the packages are installed like
>
> 2015-06-26 12:05:50,951 - Package['hadoop_2_2_*'] {'use_repos': ['HDP-2.2.6.0-2799', 'HDP-UTILS-2.2.6.0-2799']}
> 2015-06-26 12:05:50,952 - Installing package hadoop_2_2_* ('/usr/bin/yum -d 0 -e 0 -y install '--disablerepo=HDP*' --enablerepo=HDP-2.2.6.0-2799,HDP-UTILS-2.2.6.0-2799 'hadoop_2_2_*'')
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py c17b7f0
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 0681afe
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 6badfd1
>
> Diff: https://reviews.apache.org/r/35925/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 268 tests in 8.991s
>
> OK
> ----------------------------------------------------------------------
> Total run:797
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 35925: Ambari RU doesn't work with Redhat satellite
Posted by Nate Cole <nc...@hortonworks.com>.
> On June 26, 2015, 11:26 a.m., Nate Cole wrote:
> > ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py, lines 45-46
> > <https://reviews.apache.org/r/35925/diff/1/?file=993007#file993007line45>
> >
> > I think we should modify the Package "abstract class" to support an ignore_repos (or skip_repos or whatever) argument. That way we're not constantly chasing this particular line (this is the 3rd time) and we can pass it in the arguments like we do with use_repos.
>
> Dmytro Sen wrote:
> disablerepo option is used only by yumrpm.py and only with value HDP*
> Lets create a separate task for that for Ambari 2.2.0 ?
>
> Dmytro Sen wrote:
> But, yes, we will have another value for non-HDP stacks
Yes, let's create another task.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35925/#review89502
-----------------------------------------------------------
On June 26, 2015, 11:06 a.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35925/
> -----------------------------------------------------------
>
> (Updated June 26, 2015, 11:06 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
>
>
> Bugs: AMBARI-12169
> https://issues.apache.org/jira/browse/AMBARI-12169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM: If the regular repository is not used, set up RH satellite and subscribed to some particular channel for yum install, there is not repo file under /etc/yum.repos.d/, and nothing can be put into the repository url in Ambari. This can be workaround, but when ambari doing the RU, the command is:
> /usr/bin/yum -d 0 -e 0 -y install '--disablerepo=*' --enablerepo=base,HDP-UTILS-2.2.4.2,HDP-2.2.4.2 'hadoop_2_2_*'
> This will disable all the repository channels in the RH satellite. So the install will fail.
>
> After the patch all the packages are installed like
>
> 2015-06-26 12:05:50,951 - Package['hadoop_2_2_*'] {'use_repos': ['HDP-2.2.6.0-2799', 'HDP-UTILS-2.2.6.0-2799']}
> 2015-06-26 12:05:50,952 - Installing package hadoop_2_2_* ('/usr/bin/yum -d 0 -e 0 -y install '--disablerepo=HDP*' --enablerepo=HDP-2.2.6.0-2799,HDP-UTILS-2.2.6.0-2799 'hadoop_2_2_*'')
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py c17b7f0
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 0681afe
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 6badfd1
>
> Diff: https://reviews.apache.org/r/35925/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 268 tests in 8.991s
>
> OK
> ----------------------------------------------------------------------
> Total run:797
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 35925: Ambari RU doesn't work with Redhat satellite
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35925/#review89502
-----------------------------------------------------------
ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py (lines 44 - 45)
<https://reviews.apache.org/r/35925/#comment142134>
I think we should modify the Package "abstract class" to support an ignore_repos (or skip_repos or whatever) argument. That way we're not constantly chasing this particular line (this is the 3rd time) and we can pass it in the arguments like we do with use_repos.
ambari-server/src/main/resources/custom_actions/scripts/install_packages.py (line 91)
<https://reviews.apache.org/r/35925/#comment142135>
If we exclude HDP*, and include HDP-<version>, do we need to specifically say "base" here?
- Nate Cole
On June 26, 2015, 11:06 a.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35925/
> -----------------------------------------------------------
>
> (Updated June 26, 2015, 11:06 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
>
>
> Bugs: AMBARI-12169
> https://issues.apache.org/jira/browse/AMBARI-12169
>
>
> Repository: ambari
>
>
> Description
> -------
>
> PROBLEM: If the regular repository is not used, set up RH satellite and subscribed to some particular channel for yum install, there is not repo file under /etc/yum.repos.d/, and nothing can be put into the repository url in Ambari. This can be workaround, but when ambari doing the RU, the command is:
> /usr/bin/yum -d 0 -e 0 -y install '--disablerepo=*' --enablerepo=base,HDP-UTILS-2.2.4.2,HDP-2.2.4.2 'hadoop_2_2_*'
> This will disable all the repository channels in the RH satellite. So the install will fail.
>
> After the patch all the packages are installed like
>
> 2015-06-26 12:05:50,951 - Package['hadoop_2_2_*'] {'use_repos': ['HDP-2.2.6.0-2799', 'HDP-UTILS-2.2.6.0-2799']}
> 2015-06-26 12:05:50,952 - Installing package hadoop_2_2_* ('/usr/bin/yum -d 0 -e 0 -y install '--disablerepo=HDP*' --enablerepo=HDP-2.2.6.0-2799,HDP-UTILS-2.2.6.0-2799 'hadoop_2_2_*'')
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/core/providers/package/yumrpm.py c17b7f0
> ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 0681afe
> ambari-server/src/test/python/custom_actions/TestInstallPackages.py 6badfd1
>
> Diff: https://reviews.apache.org/r/35925/diff/
>
>
> Testing
> -------
>
> ----------------------------------------------------------------------
> Ran 268 tests in 8.991s
>
> OK
> ----------------------------------------------------------------------
> Total run:797
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Dmytro Sen
>
>