You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by zwwill <gi...@git.apache.org> on 2018/01/24 07:55:41 UTC
[GitHub] incubator-weex-site pull request #47: Update scroller.md
GitHub user zwwill opened a pull request:
https://github.com/apache/incubator-weex-site/pull/47
Update scroller.md
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwwill/incubator-weex-site scroller-suggest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex-site/pull/47.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #47
----
commit f25f8ed4eecc8d669b3200ea802d69e54a562976
Author: 木羽 <zw...@...>
Date: 2018-01-24T07:55:07Z
Update scroller.md
----
---
Re: [GitHub] incubator-weex-site pull request #47: Update
scroller.md
Posted by Adam Feng <cx...@gmail.com>.
Thanks for the contribution, maybe you should update the corresponding english document, too.
Thanks.
Adam Feng
On 24 Jan 2018, 3:57 PM +0800, zwwill <gi...@git.apache.org>, wrote:
> Github user zwwill commented on a diff in the pull request:
>
> https://github.com/apache/incubator-weex-site/pull/47#discussion_r163474033
>
> --- Diff: source/cn/references/components/scroller.md ---
> @@ -35,7 +35,7 @@ version: 2.1
> - `show-scrollbar {boolean}`：可选值为 `true`/ `false`，默认值为 `true`。控制是否出现滚动条。
>
> - `scroll-direction {string}`：可选为 `horizontal` 或者 `vertical`，默认值为 `vertical` 。定义滚动的方向。
> - - `scroll-direction`定义了 scroller 的滚动方向，`flex-direction` 定义了 scroller 的布局方向，两个方向必须一致。
> + - `scroll-direction`定义了 scroller 的滚动方向，样式表属性 `flex-direction` 定义了 scroller 的布局方向，两个方向必须一致。
> --- End diff --
>
> 经常有人反应 安卓下 `flex-direction` 配置无效，发现他们将 `flex-direction` 当作 `<scroller>` 的属性使用了
>
>
> ---
[GitHub] incubator-weex-site pull request #47: Update scroller.md
Posted by zwwill <gi...@git.apache.org>.
Github user zwwill commented on a diff in the pull request:
https://github.com/apache/incubator-weex-site/pull/47#discussion_r163474033
--- Diff: source/cn/references/components/scroller.md ---
@@ -35,7 +35,7 @@ version: 2.1
- `show-scrollbar {boolean}`：可选值为 `true`/ `false`，默认值为 `true`。控制是否出现滚动条。
- `scroll-direction {string}`：可选为 `horizontal` 或者 `vertical`，默认值为 `vertical` 。定义滚动的方向。
- - `scroll-direction`定义了 scroller 的滚动方向，`flex-direction` 定义了 scroller 的布局方向，两个方向必须一致。
+ - `scroll-direction`定义了 scroller 的滚动方向，样式表属性 `flex-direction` 定义了 scroller 的布局方向，两个方向必须一致。
--- End diff --
经常有人反应 安卓下 `flex-direction` 配置无效，发现他们将 `flex-direction` 当作 `<scroller>` 的属性使用了
---
[GitHub] incubator-weex-site pull request #47: Update scroller.md
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex-site/pull/47
---