[GitHub] [openwhisk] rabbah commented on a change in pull request #4678: Add NoopActivationStore to simplify local performance testing

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #4678: Add NoopActivationStore to simplify local performance testing
URL: https://github.com/apache/openwhisk/pull/4678#discussion_r334490848
 
 

 ##########
 File path: core/standalone/src/main/scala/org/apache/openwhisk/standalone/LogbackConfigurator.scala
 ##########
 @@ -39,7 +39,10 @@ object LogbackConfigurator {
 
   def initLogging(conf: Conf): Unit = {
     val ctx = LoggerFactory.getILoggerFactory.asInstanceOf[LoggerContext]
-    ctx.getLogger(org.slf4j.Logger.ROOT_LOGGER_NAME).setLevel(toLevel(conf.verbose()))
+    //Only tweak the log level if verbose option is used
+    if (conf.verbose() != 0) {
 
 Review comment:
   does this make a difference? what is the default level otherwise on the call at line 44?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services