You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2015/05/13 20:19:00 UTC

[jira] [Commented] (AMBARI-11093) Provide host predicate property validation for blueprint requests

    [ https://issues.apache.org/jira/browse/AMBARI-11093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14542354#comment-14542354 ] 

Hudson commented on AMBARI-11093:
---------------------------------

FAILURE: Integrated in Ambari-trunk-Commit #2584 (See [https://builds.apache.org/job/Ambari-trunk-Commit/2584/])
AMBARI-11093.  Implement host predicate property validation and fix issue where host (jspeidel: http://git-wip-us.apache.org/repos/asf?p=ambari.git&a=commit&h=43dd0cddf656bd54cda90e182786e304655b4765)
* ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java
* ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
* ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequest.java
* ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ScaleClusterRequest.java
* ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ProvisionClusterRequestTest.java
* ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ScaleClusterRequestTest.java
* ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BaseClusterRequest.java


> Provide host predicate property validation for blueprint requests
> -----------------------------------------------------------------
>
>                 Key: AMBARI-11093
>                 URL: https://issues.apache.org/jira/browse/AMBARI-11093
>             Project: Ambari
>          Issue Type: Task
>          Components: blueprints
>    Affects Versions: Ambari-2.1
>            Reporter: John Speidel
>            Assignee: John Speidel
>            Priority: Critical
>             Fix For: Ambari-2.1
>
>
> When specifying a host predicate via the "host_predicate" property in the cluster creation template, the predicate is compiled using the API predicate compiler which will report syntactic errors in the predicate but the property names aren't validated. So, if an invalid property name is specified in the predicate, the host group will never get matched to any host meaning that the host group will never be deployed.
> This is critical that this is fixed for 2.1 as it will cause great frustration to anyone who attempts to provision or scale a cluster and specifies a host predicate with an invalid proper name.
> When an invalid property name is specified a host predicate, this should result in a 400 response to the the user with a message which indicates the invalid properties.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)